doc: adds link to nightly code coverage report#27922
Closed
srcmake wants to merge 1 commit intonodejs:masterfrom
Closed
doc: adds link to nightly code coverage report#27922srcmake wants to merge 1 commit intonodejs:masterfrom
srcmake wants to merge 1 commit intonodejs:masterfrom
Conversation
Trott
reviewed
May 27, 2019
Adds a link to the nightly test code coverage report page to the writing-tests.md documentation.
srcmake
force-pushed
the
doc/code-coverage-link
branch
from
f558e68 to
fc42d1e
Compare
Trott
approved these changes
May 27, 2019
Member
Trott
added
the
author ready
richardlau
approved these changes
May 27, 2019
lpinca
approved these changes
May 27, 2019
BridgeAR
approved these changes
May 29, 2019
trivikr
approved these changes
May 29, 2019
Member
|
Landed in 18be288. |
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
May 30, 2019
Adds a link to the nightly test code coverage report page to the writing-tests.md documentation. PR-URL: nodejs#27922 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos
pushed a commit
that referenced
this pull request
May 31, 2019
Adds a link to the nightly test code coverage report page to the writing-tests.md documentation. PR-URL: #27922 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The writing-tests.md file leads to documentation on generating a test code coverage report, but doesn't actually link to the page with the nightly code coverage report. (Actually, the Nightly Code Coverage Report doesn't seem to be linked anywhere in the project.)
This PR adds a link to the Nightly Test Code Coverage Report in the writing-tests.md file (specifically, in the Test Coverage section).
Checklist