test: add test cases for paramEncoding 'explicit'

[oksemonenko]

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• tests and/or benchmarks are included
• commit message follows commit guidelines

[ryzokuken]

Thanks for this!

/cc @tniessen @nodejs/crypto

[tniessen]

Thanks for the ping @ryzokuken. Key pair generation is slow, I am not sure if this is worth adding three more test cases. Apart from that, LGTM.

[ChALkeR]

@tniessen There were uncovered lines and this PR should increase actual coverage.
So this should be worth it =).

[tniessen]

@ChALkeR Yes, we should definitely add one or more tests to cover those lines. I was just questioning the number of tests :) But you are right, it does not really matter if it's one or three.

[panva]

@ChALkeR Yes, we should definitely add one or more tests to cover those lines. I was just questioning the number of tests :) But you are right, it does not really matter if it's one or three.

It's ec keys, not taxing.

[ryzokuken]

LGTM

[ryzokuken]

Any idea what failed, everyone?

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/23447/

[ryzokuken]

03:26:26 /home/iojs/build/workspace/node-test-commit-plinux/nodes/ppcle-ubuntu1404/out/Release/obj.target/v8_base/deps/v8/src/bootstrapper.o:(.toc1+0x218): undefined reference to `v8::internal::StatisticsExtension::kSource'
03:26:26 /home/iojs/build/workspace/node-test-commit-plinux/nodes/ppcle-ubuntu1404/out/Release/obj.target/v8_base/deps/v8/src/bootstrapper.o:(.toc1+0x228): undefined reference to `vtable for v8::internal::StatisticsExtension'
03:26:26 collect2: error: ld returned 1 exit status
03:26:26 make[2]: *** [/home/iojs/build/workspace/node-test-commit-plinux/nodes/ppcle-ubuntu1404/out/Release/mksnapshot] Error 1

Seems to be a plinux flake, I'm seeing this multiple times everyday on unrelated PRs.

@Trott we're tracking this one, right?

[BridgeAR]

@oksemonenko thanks a lot and I hope you enjoyed the event!

[oksemonenko]

@oksemonenko thanks a lot and I hope you enjoyed the event!

@BridgeAR of course I did! Thank you very much for making my sunday!

[ryzokuken]

@BridgeAR since the CI fail is flaky, I guess it's fine to rerun CI?

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/23456/

[tniessen]

CI is green and the last failure looks a lot like a flake:

08:39:59 not ok 2562 known_issues/test-vm-timeout-escape-queuemicrotask
08:39:59   ---
08:39:59   duration_ms: 0.448
08:39:59   severity: fail
08:39:59   stack: |-
08:39:59   ...

So this should be good to go.

[Trott]

Landed in 76cffdd.