test: add test case for checking typeof mgf1Hash#27892
Closed
Nievl wants to merge 1 commit intonodejs:masterfrom
Nievl:crypto-keygen-test
Closed
test: add test case for checking typeof mgf1Hash#27892Nievl wants to merge 1 commit intonodejs:masterfrom Nievl:crypto-keygen-test
Nievl wants to merge 1 commit intonodejs:masterfrom
Nievl:crypto-keygen-test
Conversation
add test case to cover uncovered test mgf1Hash param of generateKeyPair, check typeof
addaleax
approved these changes
May 26, 2019
BridgeAR
approved these changes
May 26, 2019
BridgeAR
added
the
code-and-learn
ryzokuken
approved these changes
May 26, 2019
Collaborator
cjihrig
approved these changes
May 26, 2019
ChALkeR
approved these changes
May 26, 2019
Trott
approved these changes
May 27, 2019
Trott
added
the
author ready
gireeshpunathil
approved these changes
May 27, 2019
Contributor
|
Thanks everyone! Will land this as soon as 48 hours are up. |
Contributor
|
Landed in 12f5e0f. |
danbev
pushed a commit
that referenced
this pull request
May 29, 2019
add test case to cover uncovered test mgf1Hash param of generateKeyPair, check typeof PR-URL: #27892 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
targos
pushed a commit
that referenced
this pull request
May 31, 2019
add test case to cover uncovered test mgf1Hash param of generateKeyPair, check typeof PR-URL: #27892 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add test case to cover uncovered test mgf1Hash param of generateKeyPair,
check typeof
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes