test: add testcase for SourceTextModule custom inspect#27889
Closed
ch1ller0 wants to merge 1 commit intonodejs:masterfrom
Closed
test: add testcase for SourceTextModule custom inspect#27889ch1ller0 wants to merge 1 commit intonodejs:masterfrom
ch1ller0 wants to merge 1 commit intonodejs:masterfrom
Conversation
addaleax
approved these changes
May 26, 2019
Member
addaleax
left a comment
addaleax
left a comment
There was a problem hiding this comment.
LGTM, although I don’t think wrapping in an async function is necessary here?
Contributor
Author
thats right, it is not necessary) |
addaleax
added
the
code-and-learn
Collaborator
ryzokuken
approved these changes
May 26, 2019
Contributor
ryzokuken
left a comment
ryzokuken
left a comment
There was a problem hiding this comment.
@Kefir100 please remove any unnecessary keywords, please. Thanks for the PR. LGTM.
BridgeAR
approved these changes
May 26, 2019
Contributor
Author
|
@BridgeAR @ryzokuken fixed linter and also covered the line with getConstructorOf |
Trott
approved these changes
May 27, 2019
Trott
added
the
author ready
Collaborator
gireeshpunathil
approved these changes
May 27, 2019
Collaborator
Contributor
|
Thanks everyone! Will land this as soon as 48 hours are up. |
Contributor
|
Landed in ff66e08 🎉 |
ryzokuken
pushed a commit
that referenced
this pull request
May 29, 2019
PR-URL: #27889 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Contributor
Author
|
Thanks everyone 👍 |
Contributor
|
🎉 Thanks for the contribution! |
targos
pushed a commit
that referenced
this pull request
May 31, 2019
PR-URL: #27889 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes