test: roll WPT update for URL and harness#27822
Closed
joyeecheung wants to merge 3 commits intonodejs:masterfrom
Closed
test: roll WPT update for URL and harness#27822joyeecheung wants to merge 3 commits intonodejs:masterfrom
joyeecheung wants to merge 3 commits intonodejs:masterfrom
Conversation
Using `git node wpt resources`
So we no longer need to hack the global.location and pretend that we are in a worker anymore.
Using `git node wpt url`
Member
Author
|
cc @nodejs/testing @nodejs/open-standards |
Collaborator
Collaborator
jasnell
approved these changes
May 23, 2019
tniessen
approved these changes
May 23, 2019
targos
approved these changes
May 23, 2019
joyeecheung
added
the
author ready
Member
Author
|
Landed in 3293bbf...df22778 |
joyeecheung
added a commit
that referenced
this pull request
May 24, 2019
Using `git node wpt resources` PR-URL: #27822 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michaël Zasso <targos@protonmail.com>
joyeecheung
added a commit
that referenced
this pull request
May 24, 2019
So we no longer need to hack the global.location and pretend that we are in a worker anymore. PR-URL: #27822 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michaël Zasso <targos@protonmail.com>
joyeecheung
added a commit
that referenced
this pull request
May 24, 2019
Using `git node wpt url` PR-URL: #27822 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michaël Zasso <targos@protonmail.com>
targos
pushed a commit
that referenced
this pull request
May 28, 2019
Using `git node wpt resources` PR-URL: #27822 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michaël Zasso <targos@protonmail.com>
targos
pushed a commit
that referenced
this pull request
May 28, 2019
So we no longer need to hack the global.location and pretend that we are in a worker anymore. PR-URL: #27822 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michaël Zasso <targos@protonmail.com>
targos
pushed a commit
that referenced
this pull request
May 28, 2019
Using `git node wpt url` PR-URL: #27822 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michaël Zasso <targos@protonmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have another batch of patches for encoding tests, but would like to update the URL tests first to keep the PR small.
test: update wpt/resources to e1fddfbf80
Using
git node wpt resourcestest: use ShellTestEnvironment in WPT
So we no longer need to hack the global.location and pretend
that we are in a worker anymore.
test: update wpt/url to 418f7fabeb
Using
git node wpt urlChecklist
make -j4 test(UNIX), orvcbuild test(Windows) passes