Merged
Conversation
Collaborator
nodejs-github-bot
added
libuv
BridgeAR
force-pushed
the
v12.3.1-proposal
branch
from
6f3b4f2 to
e28f8ee
Compare
BridgeAR
added a commit
that referenced
this pull request
May 22, 2019
This release fixes a regression introduced in v12.3.0 that prevents native addons from compiling. PR-URL: #27814
Member
Author
|
@nodejs/releasers I would like to include #27792 as well if you're fine to fast track that. I guess I could highlight all commits as noteable changes but it's such a small release, it'll duplicate the complete changelog? |
Collaborator
Member
Author
Notable changes: - uv_get_constrained_memory() has been added. - A race condition in uv_async_send() has been fixed. - uv_get_free_memory() and uv_get_total_memory() now read from /proc/meminfo, which should improve correctness when called from inside an lxc container. - A failed assertion in uv_fs_poll_stop() has been fixed. - A bug in MAC addresses for IP-aliases has been fixed. Fixes: #27170 Fixes: #27493 PR-URL: #27718 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Refs https://crbug.com/v8/7848 PR-URL: #23926 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
`node.h` may only include public APIs, which `util-inl.h` is not. There does not seem to be any reason for including it, so remove it, because otherwise native addon compilation is broken due to us not shipping the `util-inl.h` header. Refs: #27631 Fixes: #27803 PR-URL: #27804 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
gengjiawen
approved these changes
May 22, 2019
BridgeAR
force-pushed
the
v12.3.1-proposal
branch
from
e28f8ee to
2817fde
Compare
Collaborator
Member
Author
|
I just included one more fix in this release and updated the release notes and the noteable changes. PTAL. V8-CI https://ci.nodejs.org/job/node-test-commit-v8-linux/2297/ |
Original commit message:
[ic] Fix handling of +0/-0 when constant field tracking is enabled
... and ensure that runtime behaviour is in sync with the IC code.
Bug: chromium:950747, v8:9113
Change-Id: Ied66c9514cbe3a4d75fc71d4fc3b19ea1538f9b2
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1561319
Reviewed-by: Toon Verwaest <verwaest@chromium.org>
Commit-Queue: Igor Sheludko <ishell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#60768}
PR-URL: #27792
Fixes: #27784
Refs: v8/v8@94c87fe
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gus Caplan <me@gus.host>
BethGriggs
approved these changes
May 22, 2019
Closed
Collaborator
BridgeAR
added a commit
to BridgeAR/node
that referenced
this pull request
May 22, 2019
Notable changes
* deps:
* Fix handling of +0/-0 when constant field tracking is enabled
(Michaël Zasso) nodejs#27792
* Fix `os.freemem()` and `os.totalmem` correctness (cjihrig)
nodejs#27718
* src:
* Fix v12.3.0 regression that prevents native addons from compiling
nodejs#27804
PR-URL: nodejs#27814
BridgeAR
added a commit
to BridgeAR/nodejs.org
that referenced
this pull request
May 22, 2019
BridgeAR
added a commit
to nodejs/nodejs.org
that referenced
this pull request
May 22, 2019
targos
added
release
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notable changes
os.freemem()andos.totalmemcorrectness (cjihrig) #27718Commits
c478884725] - deps: V8: cherry-pick 94c87fe (Michaël Zasso) #27792aed74ccb4c] - deps: upgrade to libuv 1.29.1 (cjihrig) #277187438a557af] - src: remove util-inl.h include in node.h (Anna Henningsen) #278046f7005465a] - src, lib: take control of prepareStackTrace (Gus Caplan) #2392605465a)] - src, lib: take control of prepareStackTrace (Gus Caplan) #23926