build,aix: skip ld missing symbols warning#27773
Conversation
|
/cc @miladfarca They overwhelm the logs, for sure, would be nice to get rid of them. Will this get rid of all warnings? I'm not necessarily opposed to that, just curious. |
I'm just key-mashing I have no idea what I'm doing ¯\(ツ)/¯. |
|
Not really sure if it's fully doable since |
|
@refack Do you still want this to land? Or does this suppress warnings too broadly? |
|
@miladfarca So, you suggest not merging this? The linked docs are:
That's not so illuminating, it makes it sound like the message will go to standard out. |
|
So I just ran a test with the flag added, all the Also checked for error messages and they display just fine so seems like the change might do the trick. |
|
LGTM since @miladfarca is good with it |
Great. So this needs a formal ✔️ |
42da8d4 to
e1df99b
Compare
PR-URL: nodejs#27773 Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
e1df99b to
74b4986
Compare
PR-URL: #27773 Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
On a typical node CI job we get ~68.5K of these, e.g for https://ci.nodejs.org/job/node-test-commit-aix/23246/nodes=aix61-ppc64/consoleText:
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes