Closed
Conversation
Collaborator
Collaborator
Collaborator
Member
|
@nodejs/inspector PTAL |
Original commit message: inspector: added Debugger.setInstrumentationBreakpoint method There are two possible type: - scriptParsed - breakpoint for any script, - scriptWithSourceMapParsed - breakpoint for script with sourceMappingURL. When one of the breakpoints is set then for each matched script we add breakpoint on call to top level function of that script. Node: nodejs#24687
Member
Author
|
This commit adds a method that is required to provide better-debugging experience for scripts with source maps by different IDE, e.g. VSCode. If we backport it to Node 12, we can get this support in VSCode faster. At the same time, this commit only adds the minor feature to protocol and does not change anything around, so the risk that it breaks something is minimal. |
eugeneo
approved these changes
Aug 2, 2019
Member
Author
|
V8 backport which includes this commit is coming: #28955 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original commit message:
Issue: #24687
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes