Skip to content

[v8.x] assert: fix backport regression#27202

Closed
BridgeAR wants to merge 1 commit intonodejs:v8.x-stagingfrom
BridgeAR:fix-assert-error-v8
Closed

[v8.x] assert: fix backport regression#27202
BridgeAR wants to merge 1 commit intonodejs:v8.x-stagingfrom
BridgeAR:fix-assert-error-v8

Conversation

@BridgeAR
Copy link
Member

@BridgeAR BridgeAR commented Apr 12, 2019

This fixes a regression for an error case with assert.rejects and
assert.doesNotReject.

Fixes: #27185

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@BridgeAR
assert: fix backport regression
7ce9361 
This fixes a regression for an error case with `assert.rejects` and
`assert.doesNotReject`.

Fixes: nodejs#27185
@BridgeAR BridgeAR added the v8.x label Apr 12, 2019
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 12, 2019

Lite-CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3236

@nodejs-github-bot nodejs-github-bot added the assert Issues and PRs related to the assert subsystem. label Apr 12, 2019
@BridgeAR BridgeAR mentioned this pull request Apr 12, 2019
Merged
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 12, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/22390/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 14, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/22425/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 15, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/22454/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 15, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/22460/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 16, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/22472/

MylesBorins pushed a commit that referenced this pull request Apr 16, 2019
@BridgeAR @MylesBorins
assert: fix backport regression
705935d 
This fixes a regression for an error case with `assert.rejects` and
`assert.doesNotReject`.

Fixes: #27185

PR-URL: #27202
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
@MylesBorins
Copy link
Contributor

MylesBorins commented Apr 16, 2019

landed in 705935d

@BridgeAR BridgeAR deleted the fix-assert-error-v8 branch January 20, 2020 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes

@BethGriggs BethGriggs BethGriggs approved these changes

Assignees

No one assigned

Labels

assert Issues and PRs related to the assert subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@BridgeAR @nodejs-github-bot @MylesBorins @lpinca @BethGriggs