http: add PUT,TRACE methods to support#2703
http: add PUT,TRACE methods to support#2703JungMinu wants to merge 1 commit intonodejs:masterfrom JungMinu:patch-12
Conversation
There are two more http methods to support: PUT,TRACE Add put, trace methods to support
|
Guess this should be disable |
|
@yorkie Can I ask you please explain why? |
|
No worries, I found the following line is (just curious which feature do they support?) |
|
Could you provide a testcase that this change fixes? |
|
@ChALkeR Rather than fixing, this PR provides additional cases for PUT, TRACE methods |
|
@JungMinu Are you sure that they were broken/unsupported without this pull request? If yes, please provide a testcase. If no, I see no point in this PR. |
|
@JungMinu This change is not trivial. It needs to be tested. There is already a test for this code path added in the following commit: aef0960. What is your reasoning for changing the value of |
There are two more http methods to support: PUT,TRACE
Add put, trace methods to support