Fix Travis builds by richardlau · Pull Request #27002 · nodejs/node

richardlau · 2019-03-30T01:12:31Z

Supersedes #26992 and incorporates #26968.

First commit:

build: add a `Prepare ccache` job in Travis

Combined compile and test of Node.js where lots of files need to be
compiled (e.g. after a V8 update) is exceeding the time limit for
Travis jobs (50 minutes).

Add a job to Travis that compiles Node.js but doesnt run any tests to
populate the ccache. Introduce staging and move the `Test Suite` job
into a later stage so that it can use the populated ccache.

Second commit:

build: fix skipping of flaky tests on Travis

`PARALLEL_ARGS` is overwritten in the Makefile if `JOBS` is set. Use
`CI_JS_SUITES` instead.

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
commit message follows commit guidelines

Combined compile and test of Node.js where lots of files need to be compiled (e.g. after a V8 update) is exceeding the time limit for Travis jobs (50 minutes). Add a job to Travis that compiles Node.js but doesnt run any tests to populate the ccache. Introduce staging and move the `Test Suite` job into a later stage so that it can use the populated ccache.

`PARALLEL_ARGS` is overwritten in the Makefile if `JOBS` is set. Use `CI_JS_SUITES` instead.

nodejs-github-bot · 2019-03-30T01:12:34Z

@richardlau build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/3098/pipeline

refack · 2019-03-30T02:15:06Z

Please 👍 to fast-track

Trott · 2019-03-30T02:59:06Z

Landed in 30e884f...58bf615

Combined compile and test of Node.js where lots of files need to be compiled (e.g. after a V8 update) is exceeding the time limit for Travis jobs (50 minutes). Add a job to Travis that compiles Node.js but doesnt run any tests to populate the ccache. Introduce staging and move the `Test Suite` job into a later stage so that it can use the populated ccache. PR-URL: nodejs#27002 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

`PARALLEL_ARGS` is overwritten in the Makefile if `JOBS` is set. Use `CI_JS_SUITES` instead. PR-URL: nodejs#27002 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

richardlau · 2019-03-30T05:44:23Z

Builds are now green again 🎉.

It should be safe to restart any timed out Travis pull request builds as they should pick up the refreshed ccache from the master builds.

addaleax · 2019-03-30T15:34:50Z

@richardlau Why are we skipping flaky tests on Travis in the first place? Wouldn’t dontcare be better, like we do elsewhere in CI? I’ve personally made bad experiences with skipping tests in CI only, because that means that test suite is even more likely to fail for people locally…

richardlau · 2019-03-30T15:41:10Z

@richardlau Why are we skipping flaky tests on Travis in the first place? Wouldn’t dontcare be better, like we do elsewhere in CI? I’ve personally made bad experiences with skipping tests in CI only, because that means that test suite is even more likely to fail for people locally…

¯\_(ツ)_/¯ Skipping flaky tests was introduced (albeit it wasn't working until this PR) in #23778. I have no objections to dontcare. cc @refack

refack · 2019-03-30T17:55:22Z

I have no objections to dontcare. cc @refack

~~Even with dontcare the errorlevel is set to 2. Jenkins knows to interpret that as "Unstable", AFAICT Travis doesn't.~~ (Nope, that was removed in favor of tap/xunit parsing).

I'm leaning towards minimal sanity tests in Travis (which IMHO is not CI), I would actually be happy to cull even more test categories...

Combined compile and test of Node.js where lots of files need to be compiled (e.g. after a V8 update) is exceeding the time limit for Travis jobs (50 minutes). Add a job to Travis that compiles Node.js but doesnt run any tests to populate the ccache. Introduce staging and move the `Test Suite` job into a later stage so that it can use the populated ccache. PR-URL: #27002 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

`PARALLEL_ARGS` is overwritten in the Makefile if `JOBS` is set. Use `CI_JS_SUITES` instead. PR-URL: #27002 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

Combined compile and test of Node.js where lots of files need to be compiled (e.g. after a V8 update) is exceeding the time limit for Travis jobs (50 minutes). Add a job to Travis that compiles Node.js but doesnt run any tests to populate the ccache. Introduce staging and move the `Test Suite` job into a later stage so that it can use the populated ccache. PR-URL: #27002 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Signed-off-by: Beth Griggs <Bethany.Griggs@uk.ibm.com>

`PARALLEL_ARGS` is overwritten in the Makefile if `JOBS` is set. Use `CI_JS_SUITES` instead. PR-URL: #27002 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Signed-off-by: Beth Griggs <Bethany.Griggs@uk.ibm.com>

refack · 2019-05-23T00:24:20Z

@richardlau check out https://travis-ci.com/nodejs/node/builds/112836093 for #27375

tl;dr the stages approach pays off in robustness

richardlau added 2 commits March 29, 2019 21:04

build: fix skipping of flaky tests on Travis

aa19e07

`PARALLEL_ARGS` is overwritten in the Makefile if `JOBS` is set. Use `CI_JS_SUITES` instead.

This was referenced Mar 30, 2019

build: move doc tests to separate Travis job #26992

Closed

build: fix skipping of flaky tests on Travis #26968

Closed

richardlau added the build Issues and PRs related to build files or the CI. label Mar 30, 2019

richardlau requested a review from refack March 30, 2019 02:09

refack approved these changes Mar 30, 2019

View reviewed changes

richardlau added fast-track PRs that do not need to wait for 48 hours to land. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Mar 30, 2019

Trott approved these changes Mar 30, 2019

View reviewed changes

Trott closed this Mar 30, 2019

richardlau deleted the travis-stage branch March 30, 2019 06:29

richardlau mentioned this pull request Mar 30, 2019

build: use dontcare for flaky tests in Travis #27016

Closed

2 tasks

richardlau mentioned this pull request Apr 3, 2019

doc,test: fix default maxBuffer size #22894

Closed

4 tasks

BethGriggs mentioned this pull request Apr 9, 2019

v11.14.0 proposal #27163

Merged

refack removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 23, 2019

refack added the landed label May 23, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix Travis builds#27002

Fix Travis builds#27002
richardlau wants to merge 2 commits intonodejs:masterfrom
richardlau:travis-stage

richardlau commented Mar 30, 2019 •

edited

Loading

Uh oh!

nodejs-github-bot commented Mar 30, 2019

Uh oh!

refack commented Mar 30, 2019

Uh oh!

Trott commented Mar 30, 2019

Uh oh!

richardlau commented Mar 30, 2019

Uh oh!

addaleax commented Mar 30, 2019

Uh oh!

richardlau commented Mar 30, 2019

Uh oh!

refack commented Mar 30, 2019 •

edited

Loading

Uh oh!

refack commented May 23, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

richardlau commented Mar 30, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Uh oh!

nodejs-github-bot commented Mar 30, 2019

Uh oh!

refack commented Mar 30, 2019

Uh oh!

Trott commented Mar 30, 2019

Uh oh!

richardlau commented Mar 30, 2019

Uh oh!

addaleax commented Mar 30, 2019

Uh oh!

richardlau commented Mar 30, 2019

Uh oh!

refack commented Mar 30, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

refack commented May 23, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

richardlau commented Mar 30, 2019 •

edited

Loading

refack commented Mar 30, 2019 •

edited

Loading