[v11.x backport] tls: add code for ERR_TLS_INVALID_PROTOCOL_METHOD#26952
Closed
sam-github wants to merge 2 commits intonodejs:v11.x-stagingfrom
Closed
[v11.x backport] tls: add code for ERR_TLS_INVALID_PROTOCOL_METHOD#26952sam-github wants to merge 2 commits intonodejs:v11.x-stagingfrom
sam-github wants to merge 2 commits intonodejs:v11.x-stagingfrom
Conversation
Add an error code property to invalid `secureProtocol` method exceptions. PR-URL: nodejs#24729 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
In nodejs#24729, the error was changed to be a TypeError, which is the standard type for this kind of error. However, it was Error in 11.x and earlier, so revert that single aspect, so the backport can be semver-minor.
nodejs-github-bot
added
build
Collaborator
4 tasks
Contributor
Author
|
@nodejs/crypto @nodejs/lts @nodejs/tsc PTAL, trivial backport, just cherry-picked the semver-major, then reverted the change of the error type so it is Error again, not TypeError. I'm not sure the original PR even should have been semver-major, it seems we're taking a looser approach to these fine details of error types nowadays, I guess we are finding that user's don't actually depend on them? Passing an invalid string as the |
targos
approved these changes
Mar 28, 2019
BridgeAR
approved these changes
Mar 28, 2019
Contributor
Author
|
Bundling this into #26951 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport-of: #24729
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes