doc: add note about mkdtemp() platform differences#26944
Merged
cjihrig merged 1 commit intonodejs:masterfrom Mar 30, 2019
Merged
doc: add note about mkdtemp() platform differences#26944cjihrig merged 1 commit intonodejs:masterfrom
cjihrig merged 1 commit intonodejs:masterfrom
Conversation
nodejs-github-bot
added
doc
BridgeAR
approved these changes
Mar 27, 2019
BridgeAR
added
the
author ready
lpinca
approved these changes
Mar 27, 2019
apapirovski
approved these changes
Mar 28, 2019
Contributor
apapirovski
left a comment
apapirovski
left a comment
There was a problem hiding this comment.
This seems good but I do wonder whether a warning would be more clear. I imagine most people will find this after trying to debug this issue for a while rather than before.
Contributor
Author
|
@apapirovski I'll add the warning. I think it will be a source of bugs and frustration if it does happen. Most people would never see the warning anyway. |
Contributor
Author
|
@apapirovski warning added in #26980. |
Collaborator
Collaborator
|
CI: https://ci.nodejs.org/job/node-test-pull-request/22024/ EDIT(cjihrig): CI was green. |
PR-URL: nodejs#26944 Fixes: nodejs#26435 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #26435
I'm not sure how strongly anyone feels about this, but I could potentially emit a warning if the provided prefix string ends with X.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes