Closed
Conversation
2 tasks
BridgeAR
approved these changes
Mar 26, 2019
mihalskiy
approved these changes
Mar 26, 2019
Use `require('internal/util/inspect').inspect`,
`require('internal/util/debuglog').debuglog`,
`require('internal/util').deprecate` and `Object.setPrototypeOf` instead
of `require('util')`.
Fix test in `test/parallel/test-net-access-byteswritten.js` to do not
check the `super_` property that was set when using
`require('util').inherits`.
Refs: nodejs#26546
Refs: nodejs#26896
dnlup
force-pushed
the
util_net_test_fix
branch
from
2629c82 to
1d643e5
Compare
Collaborator
BridgeAR
added
the
author ready
targos
approved these changes
Mar 30, 2019
Member
|
Landed in f0b3855 |
targos
pushed a commit
that referenced
this pull request
Mar 30, 2019
Use `require('internal/util/inspect').inspect`,
`require('internal/util/debuglog').debuglog`,
`require('internal/util').deprecate` and `Object.setPrototypeOf` instead
of `require('util')`.
Fix test in `test/parallel/test-net-access-byteswritten.js` to do not
check the `super_` property that was set when using
`require('util').inherits`.
Refs: #26546
Refs: #26896
PR-URL: #26920
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Member
|
I add the backport-requested label because the |
BethGriggs
pushed a commit
that referenced
this pull request
Apr 5, 2019
Use `require('internal/util/inspect').inspect`,
`require('internal/util/debuglog').debuglog`,
`require('internal/util').deprecate` and `Object.setPrototypeOf` instead
of `require('util')`.
Fix test in `test/parallel/test-net-access-byteswritten.js` to do not
check the `super_` property that was set when using
`require('util').inherits`.
Refs: #26546
Refs: #26896
PR-URL: #26920
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
This was referenced Apr 23, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
require('internal/util/inspect').inspect,require('internal/util/debuglog').debuglog,require('internal/util').deprecateandObject.setPrototypeOfinsteadof
require('util').Fix test in
test/parallel/test-net-access-byteswritten.jsto do notcheck the
super_property that was set when usingrequire('util').inherits.Refs: #26546
Refs: #26896
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes