Add tests for PKCS#8 private keys by sasurau4 · Pull Request #26898 · nodejs/node

sasurau4 · 2019-03-25T04:13:24Z

I added tests for unencrypted PKCS#8 private keys.
I generated the test PKCS#8 private keys by converting test_rsa_privkey,pem and test_dsa_privkey.pem by openssl command.

Refs: #24928

~~I ran make -j4 test command, but failed.~~

detailed error log

... make[2]: Leaving directory '/home/ihara/hobby/node/test/addons/not-a-binding/build' Building addon in /home/ihara/hobby/node/test/addons/openssl-client-cert-engine /home/ihara/hobby/node/tools/build-addons.js:58 main(process.argv[3]).catch((err) => setImmediate(() => { throw err; })); ^

Error: spawn /home/ihara/hobby/node/out/Release/node EACCES at Process.ChildProcess._handle.onexit (internal/child_process.js:246:19) at onErrorNT (internal/child_process.js:431:16) at processTicksAndRejections (internal/process/task_queues.js:81:17) Makefile:385: recipe for target 'test/addons/.buildstamp' failed make[1]: *** [test/addons/.buildstamp] Error 1 make[1]: *** Waiting for unfinished jobs.... touch /home/ihara/hobby/node/out/Release/obj.target/rename_node_bin_win.stamp g++ -o /home/ihara/hobby/node/out/Release/cctest -pthread -rdynamic -m64 -Wl,--whole-archive,/home/ihara/hobby/node/out/Release/obj.target/deps/zlib/libzlib.a -Wl,--no-whole-archive -Wl,--whole-archive,/home/ihara/hobby/node/out/Release/obj.target/deps/uv/libuv.a -Wl,--no-whole-archive -Wl,-z,noexecstack -Wl,--whole-archive /home/ihara/hobby/node/out/Release/obj.target/deps/v8/gypfiles/libv8_base.a -Wl,--no-whole-archive -Wl,-z,relro -Wl,-z,now -Wl,--whole-archive,/home/ihara/hobby/node/out/Release/obj.target/deps/openssl/libopenssl.a -Wl,--no-whole-archive -pthread -Wl,--start-group /home/ihara/hobby/node/out/Release/obj.target/cctest/test/cctest/node_test_fixture.o /home/ihara/hobby/node/out/Release/obj.target/cctest/test/cctest/test_aliased_buffer.o /home/ihara/hobby/node/out/Release/obj.target/cctest/test/cctest/test_base64.o /home/ihara/hobby/node/out/Release/obj.target/cctest/test/cctest/test_node_postmortem_metadata.o /home/ihara/hobby/node/out/Release/obj.target/cctest/test/cctest/test_environment.o /home/ihara/hobby/node/out/Release/obj.target/cctest/test/cctest/test_linked_binding.o /home/ihara/hobby/node/out/Release/obj.target/cctest/test/cctest/test_platform.o /home/ihara/hobby/node/out/Release/obj.target/cctest/test/cctest/test_report_util.o /home/ihara/hobby/node/out/Release/obj.target/cctest/test/cctest/test_traced_value.o /home/ihara/hobby/node/out/Release/obj.target/cctest/test/cctest/test_util.o /home/ihara/hobby/node/out/Release/obj.target/cctest/test/cctest/test_url.o /home/ihara/hobby/node/out/Release/obj.target/cctest/test/cctest/test_inspector_socket.o /home/ihara/hobby/node/out/Release/obj.target/cctest/test/cctest/test_inspector_socket_server.o /home/ihara/hobby/node/out/Release/obj.target/libnode.a /home/ihara/hobby/node/out/Release/obj.target/deps/gtest/libgtest.a /home/ihara/hobby/node/out/Release/obj.target/deps/histogram/libhistogram.a /home/ihara/hobby/node/out/Release/obj.target/deps/v8/gypfiles/libv8_libplatform.a /home/ihara/hobby/node/out/Release/obj.target/tools/icu/libicui18n.a /home/ihara/hobby/node/out/Release/obj.target/deps/zlib/libzlib.a /home/ihara/hobby/node/out/Release/obj.target/deps/http_parser/libhttp_parser.a /home/ihara/hobby/node/out/Release/obj.target/deps/llhttp/libllhttp.a /home/ihara/hobby/node/out/Release/obj.target/deps/cares/libcares.a /home/ihara/hobby/node/out/Release/obj.target/deps/uv/libuv.a /home/ihara/hobby/node/out/Release/obj.target/deps/nghttp2/libnghttp2.a /home/ihara/hobby/node/out/Release/obj.target/deps/brotli/libbrotli.a /home/ihara/hobby/node/out/Release/obj.target/deps/openssl/libopenssl.a /home/ihara/hobby/node/out/Release/obj.target/deps/v8/gypfiles/libv8_base.a /home/ihara/hobby/node/out/Release/obj.target/deps/v8/gypfiles/libv8_libbase.a /home/ihara/hobby/node/out/Release/obj.target/deps/v8/gypfiles/libv8_libsampler.a /home/ihara/hobby/node/out/Release/obj.target/tools/icu/libicuucx.a /home/ihara/hobby/node/out/Release/obj.target/tools/icu/libicudata.a /home/ihara/hobby/node/out/Release/obj.target/tools/icu/libicustubdata.a /home/ihara/hobby/node/out/Release/obj.target/deps/v8/gypfiles/libv8_snapshot.a -ldl -lrt -lm -Wl,--end-group Makefile:291: recipe for target 'test' failed make: *** [test] Error 2

~~My environment is Ubuntu 18.04.2 LTS and succeeded when I ran make test-only command.~~

~~Please help me~~ 🙏

Updated: solved the above problem.

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
commit message follows commit guidelines

bnoordhuis

LGTM, thanks for picking this up!

bnoordhuis · 2019-03-25T13:48:40Z

test/parallel/test-crypto-rsa-dsa.js

+
+  assert.strictEqual(verify.verify(dsaPubPem, signature, 'hex'), true);
+
+  // Test the legacy 'DSS1' name.


I'd be okay with dropping this, that's already checked around line 250.

In my curious, is DSS1 same as SHA-1? 🤔
I found following line in Node.js Project but I couldn't find what happened historically about the relationship between DSS1 and SHA-1 from Google search.

node/src/node_crypto.cc

Line 4459 in b4f58c2

// Historically, "dss1" and "DSS1" were DSA aliases for SHA-1

DSS1 stands for DSA (Digital Signature Algorithm) with SHA-1 as the hash function. It's a long-deprecated (and now removed) openssl synonym from when openssl conflated public key algorithms with their hash functions.

I see. Thanks 👍 👍 👍

BridgeAR · 2019-03-25T16:23:32Z

@sasurau4 the problem about the test suite can be circumvented by running the tests directly with: python tools/test.py -j4. This is a problem with GYP right now and AFAIK there is no solution so far.

nodejs-github-bot · 2019-03-25T16:26:00Z

CI: https://ci.nodejs.org/job/node-test-pull-request/21878/

sasurau4 · 2019-03-26T00:59:10Z

@BridgeAR The tests succeeded when I ran python tools/test.py -j4. Thanks for your response 👍

test/parallel/test-crypto-rsa-dsa.js

sasurau4 · 2019-03-26T23:31:06Z

@tniessen I fixed pointed out. Thanks for your review 👍

nodejs-github-bot · 2019-03-27T11:06:03Z

CI: https://ci.nodejs.org/job/node-test-pull-request/21956/

danbev · 2019-03-28T04:54:55Z

Landed in 85546c2.

PR-URL: #26898 Refs: #24928 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Tobias Nießen <tniessen@tnie.de>

nodejs-github-bot added the test Issues and PRs related to the tests. label Mar 25, 2019

sasurau4 changed the title ~~Add tests for pkcs8 private keys~~ Add tests for #PKCS#8 private keys Mar 25, 2019

sasurau4 added 2 commits March 25, 2019 13:37

test: add test about unencrypted PKCS#8 private key for RSA

0a0e4c3

test: add test about unencrypted PKCS#8 private key for DSA

57fd106

sasurau4 force-pushed the add-tests-for-pkcs8-private-keys branch from 66f3032 to 57fd106 Compare March 25, 2019 04:38

Trott added the crypto Issues and PRs related to the crypto subsystem. label Mar 25, 2019

sasurau4 marked this pull request as ready for review March 25, 2019 05:01

bnoordhuis approved these changes Mar 25, 2019

View reviewed changes

jasnell approved these changes Mar 25, 2019

View reviewed changes

BridgeAR approved these changes Mar 25, 2019

View reviewed changes

BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 25, 2019

test: remove excess test about unencrypted PKCS#8 private key for DSS1

a2dbfb7

tniessen approved these changes Mar 26, 2019

View reviewed changes

test/parallel/test-crypto-rsa-dsa.js Outdated Show resolved Hide resolved

test/parallel/test-crypto-rsa-dsa.js Outdated Show resolved Hide resolved

sasurau4 added 2 commits March 27, 2019 08:21

test: replace pkcs8 to #PKCS#8 in comments for consistency

c021104

test: add missing period in comments about crypto test

4449c10

tniessen changed the title ~~Add tests for #PKCS#8 private keys~~ Add tests for PKCS#8 private keys Mar 27, 2019

danbev closed this Mar 28, 2019

BethGriggs mentioned this pull request Apr 9, 2019

v11.14.0 proposal #27163

Merged

MylesBorins added the land-on-v10.x label May 16, 2019

BethGriggs mentioned this pull request May 16, 2019

v10.16.0 proposal #27514

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add tests for PKCS#8 private keys#26898

Add tests for PKCS#8 private keys#26898
sasurau4 wants to merge 5 commits intonodejs:masterfrom
sasurau4:add-tests-for-pkcs8-private-keys

sasurau4 commented Mar 25, 2019 •

edited

Loading

Uh oh!

bnoordhuis left a comment

Uh oh!

bnoordhuis Mar 25, 2019

Uh oh!

sasurau4 Mar 26, 2019

Uh oh!

bnoordhuis Mar 27, 2019

Uh oh!

sasurau4 Mar 27, 2019

Uh oh!

BridgeAR commented Mar 25, 2019

Uh oh!

nodejs-github-bot commented Mar 25, 2019

Uh oh!

sasurau4 commented Mar 26, 2019

Uh oh!

Uh oh!

Uh oh!

sasurau4 commented Mar 26, 2019

Uh oh!

nodejs-github-bot commented Mar 27, 2019

Uh oh!

danbev commented Mar 28, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants


		assert.strictEqual(verify.verify(dsaPubPem, signature, 'hex'), true);

		// Test the legacy 'DSS1' name.

Uh oh!

Conversation

sasurau4 commented Mar 25, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Uh oh!

bnoordhuis left a comment

Choose a reason for hiding this comment

Uh oh!

bnoordhuis Mar 25, 2019

Choose a reason for hiding this comment

Uh oh!

sasurau4 Mar 26, 2019

Choose a reason for hiding this comment

Uh oh!

bnoordhuis Mar 27, 2019

Choose a reason for hiding this comment

Uh oh!

sasurau4 Mar 27, 2019

Choose a reason for hiding this comment

Uh oh!

BridgeAR commented Mar 25, 2019

Uh oh!

nodejs-github-bot commented Mar 25, 2019

Uh oh!

sasurau4 commented Mar 26, 2019

Uh oh!

Uh oh!

Uh oh!

sasurau4 commented Mar 26, 2019

Uh oh!

nodejs-github-bot commented Mar 27, 2019

Uh oh!

danbev commented Mar 28, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

sasurau4 commented Mar 25, 2019 •

edited

Loading