Change error message to not defined#26857
Closed
MohammedEssehemy wants to merge 1 commit intonodejs:masterfrom
Closed
Change error message to not defined#26857MohammedEssehemy wants to merge 1 commit intonodejs:masterfrom
MohammedEssehemy wants to merge 1 commit intonodejs:masterfrom
Conversation
nodejs-github-bot
added
doc
MohammedEssehemy
force-pushed
the
patch-1
branch
from
6892ad4 to
ac2480e
Compare
BridgeAR
approved these changes
Mar 22, 2019
MohammedEssehemy
force-pushed
the
patch-1
branch
2 times, most recently
from
2947759 to
13fc791
Compare
Trott
reviewed
Mar 22, 2019
doc/api/errors.md
Outdated
Member
There was a problem hiding this comment.
This is fine as it's an improvement over what's there, but two totally insignificant suggestions to consider:
- Put a period at the end of the comment as it's a full sentence.
- Maybe instead of "not defined", it should be "undeclared" or even "non-existent"? Those are the terms I see used in the MDN article on ReferenceError, so might as well steal from them. (I looked in the spec too but I don't think the language there would be helpful here, at least not as far as I saw.)
Contributor
Author
There was a problem hiding this comment.
- for the period I've added it
- I think
not definedwill be closer to the error thrown which will beReferenceError: z is not defined.
Member
There was a problem hiding this comment.
(The period isn't showing up in the GitHub interface. Do you need to push or force-push to your origin maybe?)
Contributor
Author
There was a problem hiding this comment.
Sorry for that, It's now here.
Trott
approved these changes
Mar 22, 2019
MohammedEssehemy
force-pushed
the
patch-1
branch
from
13fc791 to
802fa22
Compare
lpinca
approved these changes
Mar 22, 2019
MohammedEssehemy
force-pushed
the
patch-1
branch
from
802fa22 to
3adf94b
Compare
Member
|
Seems fast-trackable. If you are a Collaborator and you agree, 👍 here! |
vsemozhetbyt
approved these changes
Mar 22, 2019
vsemozhetbyt
added
the
author ready
Member
Contributor
|
Landed in a7a8714 |
targos
pushed a commit
to targos/node
that referenced
this pull request
Mar 27, 2019
PR-URL: nodejs#26857 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
targos
pushed a commit
that referenced
this pull request
Mar 27, 2019
PR-URL: #26857 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
BethGriggs
pushed a commit
that referenced
this pull request
Apr 17, 2019
PR-URL: #26857 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
May 16, 2019
PR-URL: #26857 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
This was referenced May 29, 2019
This was referenced May 29, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not defined is not identical to undefined
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes