process: run RunBootstrapping in CreateEnvironment by joyeecheung · Pull Request #26788 · nodejs/node

joyeecheung · 2019-03-19T22:42:37Z

Also creates CreateMainEnvironment to encapsulate the code
creating the main environment from the provided Isolate data
and arguments.

This should be easier to review with https://github.com/nodejs/node/pull/26788/files?w=1

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
commit message follows commit guidelines

nodejs-github-bot · 2019-03-19T22:42:39Z

@joyeecheung build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2983/pipeline

joyeecheung · 2019-03-19T22:50:11Z

src/node.cc

My thinking was when we implement snapshot, this could be where the context is deserialized from the snapshot (as opposed to using NewContext). Note that to deserialize the snapshot properly we need to reinstall per-isolate callbacks, including the ones installed in SetIsolateUpForNode, so we may need to stop using NewIsolate at that point. We also need to restore inspector states after deserialization as those are discarded when the snapshot is generated, so it makes sense to me to encapsulate all this together.

joyeecheung · 2019-03-19T22:53:57Z

CI: https://ci.nodejs.org/job/node-test-pull-request/21675/

joyeecheung · 2019-03-20T16:25:18Z

Resume: https://ci.nodejs.org/job/node-test-pull-request/21692/

cc @addaleax @nodejs/process

joyeecheung · 2019-03-22T00:38:40Z

Cross referencing: #26334 (comment)

This detaches bootstraping and pre-execution in our C++ API, so CreateEnvironment actually provides an incomplete Node.js context. I am not sure if that's desirable, maybe we should also run a script that runs through parts of pre-exeuction for CreateEnvironment() instead? If so what should be run?

joyeecheung · 2019-03-22T02:52:51Z

Rebased and added a environment.js bootstrap script for CreateEnvironment to run pre-exeuction. @addaleax Can you take another look?

CI: ~~https://ci.nodejs.org/job/node-test-pull-request/21753/~~ https://ci.nodejs.org/job/node-test-pull-request/21774/

joyeecheung · 2019-03-22T03:26:45Z

src/api/environment.cc

Since we are splitting RunBootstrapping and StartExecution, this requires the user not to pass any arguments that result in an async operation done in pre-execution at the moment. This is not ideal, but we may be able to split what's done in environment.js in the future to make sure nothing async is done during that...then the bootstrap will be divided into three phases:

Up to node.js: no async operation is allowed, no access to run time states

environment.js: no async operation is allowed, but access to run time states is allowed (warnings emitted here must be done synchronously)

pre_execution.js: both are allowed, but the embedder would have to call this themselves somehow and make sure it plays with how they run the event loops.

nodejs-github-bot · 2019-03-26T18:09:01Z

CI: https://ci.nodejs.org/job/node-test-pull-request/21934/

joyeecheung · 2019-03-26T18:09:20Z

https://ci.nodejs.org/job/node-test-pull-request/21934/

@addaleax this changed quite a bit since last reviews (mostly, CreateEnvironment now runs prepareMainThreadExecution). Can you take a look again? Thanks!

BridgeAR · 2019-03-27T16:32:31Z

@joyeecheung seems like this needs another rebase :/

Also creates `CreateMainEnvironment` to encapsulate the code creating the main environment from the provided Isolate data and arguments.

nodejs-github-bot · 2019-03-31T01:59:00Z

CI: https://ci.nodejs.org/job/node-test-pull-request/22049/

nodejs-github-bot · 2019-04-01T04:01:33Z

CI: https://ci.nodejs.org/job/node-test-pull-request/22086/

nodejs-github-bot · 2019-04-02T00:19:07Z

CI: https://ci.nodejs.org/job/node-test-pull-request/22105/

joyeecheung · 2019-04-02T09:31:17Z

If there are no more reviews I am going to land this later today.

joyeecheung · 2019-04-03T00:48:33Z

Landed in 1944265

Also creates `CreateMainEnvironment` to encapsulate the code creating the main environment from the provided Isolate data and arguments. PR-URL: nodejs#26788 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Refael Ackermann <refack@gmail.com>

Also creates `CreateMainEnvironment` to encapsulate the code creating the main environment from the provided Isolate data and arguments. PR-URL: #26788 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Refael Ackermann <refack@gmail.com>

Also creates `CreateMainEnvironment` to encapsulate the code creating the main environment from the provided Isolate data and arguments. PR-URL: #26788 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Refael Ackermann <refack@gmail.com> Signed-off-by: Beth Griggs <Bethany.Griggs@uk.ibm.com>

nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Mar 19, 2019

joyeecheung commented Mar 19, 2019

View reviewed changes

addaleax approved these changes Mar 22, 2019

View reviewed changes

addaleax mentioned this pull request Mar 22, 2019

Restrict process and Buffer globals to CommonJS #26334

Closed

4 tasks

joyeecheung force-pushed the create-env branch 2 times, most recently from 04d2c6e to cb956fc Compare March 22, 2019 02:49

joyeecheung commented Mar 22, 2019

View reviewed changes

joyeecheung mentioned this pull request Mar 22, 2019

CI failures: 20190322 nodejs/reliability#21

Closed

joyeecheung force-pushed the create-env branch from d57f3d4 to e9e6ef2 Compare March 26, 2019 18:05

refack approved these changes Mar 27, 2019

View reviewed changes

process: run RunBootstrapping in CreateEnvironment

ba9d46e

Also creates `CreateMainEnvironment` to encapsulate the code creating the main environment from the provided Isolate data and arguments.

joyeecheung force-pushed the create-env branch from e9e6ef2 to ba9d46e Compare March 31, 2019 01:58

BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 1, 2019

joyeecheung mentioned this pull request Apr 2, 2019

CI failures: 20190330-20190402 nodejs/reliability#22

Closed

joyeecheung closed this Apr 3, 2019

joyeecheung mentioned this pull request Apr 3, 2019

Userland access to internalBinding (at one's own risk) #27061

Closed

BethGriggs mentioned this pull request Apr 9, 2019

v11.14.0 proposal #27163

Merged

This was referenced Feb 22, 2020

fix: don't run environment bootstrapper electron/electron#22342

Merged

src: don't run bootstrapper in CreateEnvironment #31910

Closed

Uh oh!

Conversation

joyeecheung commented Mar 19, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Uh oh!

nodejs-github-bot commented Mar 19, 2019

Uh oh!

joyeecheung Mar 19, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

joyeecheung commented Mar 19, 2019

Uh oh!

joyeecheung commented Mar 20, 2019

Uh oh!

joyeecheung commented Mar 22, 2019

Uh oh!

joyeecheung commented Mar 22, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

joyeecheung Mar 22, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nodejs-github-bot commented Mar 26, 2019

Uh oh!

joyeecheung commented Mar 26, 2019

Uh oh!

BridgeAR commented Mar 27, 2019

Uh oh!

nodejs-github-bot commented Mar 31, 2019

Uh oh!

nodejs-github-bot commented Apr 1, 2019

Uh oh!

nodejs-github-bot commented Apr 2, 2019

Uh oh!

joyeecheung commented Apr 2, 2019

Uh oh!

joyeecheung commented Apr 3, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

joyeecheung commented Mar 19, 2019 •

edited

Loading

joyeecheung Mar 19, 2019 •

edited

Loading

joyeecheung commented Mar 22, 2019 •

edited

Loading

joyeecheung Mar 22, 2019 •

edited

Loading