https: remove usage of public require('util')#26772
Closed
dnlup wants to merge 1 commit intonodejs:masterfrom
Closed
https: remove usage of public require('util')#26772dnlup wants to merge 1 commit intonodejs:masterfrom
dnlup wants to merge 1 commit intonodejs:masterfrom
Conversation
Use `require('internal/util/debuglog').debuglog`
and `Object.setPrototypeOf` instead of `require('util').debuglog`
and `require('util').inherits`.
Refs: nodejs#26546
BridgeAR
approved these changes
Mar 22, 2019
Member
BridgeAR
added
the
author ready
ZYSzys
approved these changes
Mar 22, 2019
jasnell
approved these changes
Mar 22, 2019
Member
pull bot
pushed a commit
to SimenB/node
that referenced
this pull request
Mar 23, 2019
Use `require('internal/util/debuglog').debuglog`
and `Object.setPrototypeOf` instead of `require('util').debuglog`
and `require('util').inherits`.
Refs: nodejs#26546
PR-URL: nodejs#26772
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Contributor
|
Landed in cd3a9ee 🎉 |
This was referenced Apr 23, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
require('internal/util/debuglog').debuglogand
Object.setPrototypeOfinstead ofrequire('util').debuglogand
require('util').inherits.Refs: #26546
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes