build: update configure for Node.js 12#26719
Merged
richardlau merged 1 commit intonodejs:masterfrom Mar 22, 2019
Merged
Conversation
Member
Author
|
Note that this check is a warning and doesn't prevent you attempting to use older compilers. |
Member
Author
targos
approved these changes
Mar 17, 2019
Contributor
|
If this is just a warning, perhaps the language in the commit message is a bit too strong? |
Member
Author
Contributor
IMHO that makes this not semver-major, just a "don't land on X" |
Member
|
I agree. #26714 being semver-major is enough |
refack
reviewed
Mar 17, 2019
Member
Author
|
Updated the commit message and clang level. PTAL. New CI: https://ci.nodejs.org/job/node-test-pull-request/21714/ (✔️) |
refack
approved these changes
Mar 22, 2019
Contributor
|
I think it's good to capture the state of things with this PR right now. |
BridgeAR
approved these changes
Mar 22, 2019
Update supported level of gcc to 6.3.0 and clang to 8.0.0. Refs: nodejs#26714 PR-URL: nodejs#26719 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Member
Author
|
Landed in 41ba699. |
This was referenced Apr 23, 2019
This was referenced Oct 21, 2019
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: #26714
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes