Remove public util use in lib/vm.js and lib/zlib.js

[digitaldina]

Removed public use of util in lib/vm.js and lib/zlib.js

Checklist

• commit message follows commit guidelines

[tniessen]

Welcome @dinaelhanan and thank you for your contribution. Your changes to zlib.js cause the following error:

zlib.js:35
    isAnyArrayBuffer,
    ^
TypeError: Cannot destructure property `isAnyArrayBuffer` of 'undefined' or 'null'.
    at zlib.js:34:10
    at NativeModule.compile (internal/bootstrap/loaders.js:302:5)
    at Function.nativeModuleRequire [as require] (internal/bootstrap/loaders.js:204:7)
    at Function.Module._load (internal/modules/cjs/loader.js:591:25)
    at Module.require (internal/modules/cjs/loader.js:719:19)
    at require (internal/modules/cjs/helpers.js:14:16)
    at Object.<anonymous> (/home/travis/build/nodejs/node/deps/npm/node_modules/node-fetch-npm/src/index.js:12:14)
    at Module._compile (internal/modules/cjs/loader.js:813:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:824:10)
    at Module.load (internal/modules/cjs/loader.js:680:32)

You can find information about building and testing node locally here. Let us know if you need assistance.

[digitaldina]

@ZYSzys any clues why I'm getting this error? appreciate the help :)

[digitaldina]

@ZYSzys hey, I've made few changes but I didn't touch isAnyArrayBuffer, however, I'm getting errors on it. Any ideas why?

[BridgeAR]

@dinaelhanan the reason for it is a cyclic structure. The former loading order allowed the module to properly resolve. Some changes reference them self, so one module returns undefined. It's important to load modules in the correct order and not every module can just plainly be replaced.

[BridgeAR]

Lite CI https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3006/

[digitaldina]

@BridgeAR ahhhh makes sense!

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/21955/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/22034/

[digitaldina]

@ZYSzys should be good but it's still showing an error :/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/22156/

[BridgeAR]

@dinaelhanan it turns out that after a lot of similar PRs like this one landed that util is not loaded internally anymore by default (which is great and the actual goal behind all this).

AssertionError [ERR_ASSERTION]: These modules were not loaded:
  NativeModule util

    at Object.<anonymous> (/home/iojs/build/workspace/node-test-commit-linux-containered/test/parallel/test-bootstrap-modules.js:119:8)

Would you be so kind and update the test as well so this can land? :)

[digitaldina]

@BridgeAR done, let me know if there's anything I need to fix 👍

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/22273/

[ZYSzys]

@dinaelhanan It seems that there is still something wrong in test-bootstrap-modules.js, it would be great if you can investigate and fix it :)

(Maybe it would be less painful if you can do a git rebase firstly)

It's weird that our travis CI passed and didn't catch that error before :D

[BridgeAR]

@dinaelhanan sorry that this did not go better but please have another look. Thanks :)

[richardlau]

@dinaelhanan It seems that there is still something wrong in test-bootstrap-modules.js, it would be great if you can investigate and fix it :)

(Maybe it would be less painful if you can do a git rebase firstly)

It's weird that our travis CI passed and didn't catch that error before :D

It was a bug that was introduced into the Travis scripts that has been fixed: #27176
The test did fail in Travis but the aformentioned bug meant the job status didn't fail: https://travis-ci.com/nodejs/node/jobs/190734809#L1161-L1181

[BridgeAR]

This seems outdated and the specific changes have already landed else wise.

@dinaelhanan thank you very much for your contribution and I am sorry that this could not land! Please feel free to see if there's not something else for you that you would like to contribute with instead!