lib: use const where possible#26679
Closed
JungMinu wants to merge 1 commit intonodejs:masterfrom
JungMinu:const
Closed
lib: use const where possible#26679JungMinu wants to merge 1 commit intonodejs:masterfrom JungMinu:const
JungMinu wants to merge 1 commit intonodejs:masterfrom
JungMinu:const
Conversation
use const instead of var where possible
Member
|
We usually reject PRs for the |
Member
|
If you want to try to get a
The PR may still get rejected due to churn etc.! But there is at least some support for the idea that we keep getting these kinds of PRs so it may be time to just fix it once and for all. So it might get accepted. |
BridgeAR
added a commit
to BridgeAR/node
that referenced
this pull request
Mar 28, 2019
Member
|
Superseded by #26915 |
This was referenced Mar 11, 2021
This was referenced May 25, 2021
This was referenced May 25, 2021
This was referenced Apr 7, 2022
This was referenced Jan 31, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
use
constinstead ofvarwhere possibleChecklist
make -j4 test(UNIX), orvcbuild test(Windows) passes