Closed
Conversation
TSC voted in Gireesh today. Add him to the TSC list in the README. Closes: nodejs#26186
Trott
added
the
notable-change
Member
|
thanks @Trott ! I am not sure if there is any actionable on my part on this PR / any onboarding activity; pls advise! |
richardlau
approved these changes
Mar 14, 2019
targos
approved these changes
Mar 14, 2019
BethGriggs
approved these changes
Mar 14, 2019
BridgeAR
approved these changes
Mar 14, 2019
joyeecheung
approved these changes
Mar 14, 2019
addaleax
approved these changes
Mar 14, 2019
cjihrig
approved these changes
Mar 14, 2019
Member
Author
You can review the PR (confirm the information and formatting is correct) just like any other Collaborator, but other than that, nothing actionable on this PR. |
Member
Author
|
Seems no reason to leave this open 48 hours. 👍 here to fast-track. |
Trott
added
fast-track
gireeshpunathil
approved these changes
Mar 14, 2019
vsemozhetbyt
approved these changes
Mar 14, 2019
vsemozhetbyt
added
the
meta
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Mar 14, 2019
TSC voted in Gireesh today. Add him to the TSC list in the README. Closes: nodejs#26186 PR-URL: nodejs#26657 Fixes: nodejs#26186 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Member
Author
|
Landed in 8549ac0 🎉 |
targos
pushed a commit
to targos/node
that referenced
this pull request
Mar 27, 2019
TSC voted in Gireesh today. Add him to the TSC list in the README. Closes: nodejs#26186 PR-URL: nodejs#26657 Fixes: nodejs#26186 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
targos
pushed a commit
that referenced
this pull request
Mar 27, 2019
TSC voted in Gireesh today. Add him to the TSC list in the README. Closes: #26186 PR-URL: #26657 Fixes: #26186 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
This was referenced Mar 11, 2021
This was referenced May 25, 2021
This was referenced Apr 7, 2022
This was referenced Jan 31, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
13 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TSC voted in Gireesh today. Add him to the TSC list in the README.
Closes: #26186
@gireeshpunathil
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes