test: fix syntax error in test-dns-idna2008.js when failing#26570
Merged
refack merged 1 commit intonodejs:masterfrom Mar 12, 2019
Merged
test: fix syntax error in test-dns-idna2008.js when failing#26570refack merged 1 commit intonodejs:masterfrom
refack merged 1 commit intonodejs:masterfrom
Conversation
refack
added
dns
Contributor
Author
jasnell
approved these changes
Mar 10, 2019
cjihrig
approved these changes
Mar 10, 2019
Trott
added
the
author ready
BridgeAR
approved these changes
Mar 10, 2019
Contributor
Author
|
Actually since right now master is broken, I'd like to fast-track this. |
Trott
reviewed
Mar 10, 2019
Contributor
Author
Trott
approved these changes
Mar 11, 2019
bnoordhuis
reviewed
Mar 11, 2019
Member
bnoordhuis
left a comment
bnoordhuis
left a comment
There was a problem hiding this comment.
Can you mention in the commit log the commit that introduced the bug? It's 9613221 "test: de-flake test-dns-idna2008.js", isn't it?
refack
force-pushed
the
fix-idna2008-test++
branch
from
57eac2d to
8b6d454
Compare
Contributor
Author
Done. |
Contributor
Author
|
Ping @nodejs/testing, I'd like to land this tonight to unbreak CI: https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/5243/ |
bnoordhuis
approved these changes
Mar 12, 2019
Fixes a bug I introduced in 9613221 PR-URL: nodejs#26570 Refs: nodejs#25870 Refs: nodejs#26473 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
refack
removed
author ready
refack
force-pushed
the
fix-idna2008-test++
branch
from
8b6d454 to
f77555f
Compare
BridgeAR
pushed a commit
that referenced
this pull request
Mar 13, 2019
Fixes a bug I introduced in 9613221 PR-URL: #26570 Refs: #25870 Refs: #26473 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
BridgeAR
pushed a commit
that referenced
this pull request
Mar 14, 2019
Fixes a bug I introduced in 9613221 PR-URL: #26570 Refs: #25870 Refs: #26473 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
Mar 14, 2019
Fixes a bug I introduced in 9613221 PR-URL: nodejs#26570 Refs: nodejs#25870 Refs: nodejs#26473 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
BridgeAR
pushed a commit
that referenced
this pull request
Mar 14, 2019
Fixes a bug I introduced in 9613221 PR-URL: #26570 Refs: #25870 Refs: #26473 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: #25870
Refs: #26473
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes