src: forbid access to CLI options before bootstrapping is done#26476
Closed
joyeecheung wants to merge 1 commit intonodejs:masterfrom
Closed
src: forbid access to CLI options before bootstrapping is done#26476joyeecheung wants to merge 1 commit intonodejs:masterfrom
joyeecheung wants to merge 1 commit intonodejs:masterfrom
Conversation
nodejs-github-bot
added
async_hooks
Member
Author
|
CI: https://ci.nodejs.org/job/node-test-pull-request/21273/ (:heavy_check_mark:) |
addaleax
approved these changes
Mar 6, 2019
BridgeAR
approved these changes
Mar 6, 2019
richardlau
approved these changes
Mar 6, 2019
BridgeAR
added
the
author ready
Member
Author
|
Landed in d57d099 |
joyeecheung
added a commit
that referenced
this pull request
Mar 9, 2019
PR-URL: #26476 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Member
|
This lands cleanly v11.x but it causes test failures. Please open a manual backport for this. I guess this relies on some other commits that have to be backported as well (likely the ones I marked as requiring a backport to v11). |
targos
pushed a commit
that referenced
this pull request
Mar 28, 2019
PR-URL: #26476 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
targos
pushed a commit
that referenced
this pull request
Mar 30, 2019
PR-URL: #26476 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes