src: cleanup in all return paths in node::Start#26471
Merged
gireeshpunathil merged 1 commit intonodejs:masterfrom Mar 8, 2019
Merged
src: cleanup in all return paths in node::Start#26471gireeshpunathil merged 1 commit intonodejs:masterfrom
gireeshpunathil merged 1 commit intonodejs:masterfrom
Conversation
nodejs-github-bot
added
the
c++
addaleax
approved these changes
Mar 6, 2019
richardlau
approved these changes
Mar 6, 2019
cjihrig
approved these changes
Mar 6, 2019
joyeecheung
approved these changes
Mar 6, 2019
Member
joyeecheung
left a comment
joyeecheung
left a comment
There was a problem hiding this comment.
Makes you wonder maybe this should be some kind of scope...but then it would be nice if the Node instance can be RAII
BridgeAR
approved these changes
Mar 6, 2019
Member
BridgeAR
added
the
author ready
Member
Author
|
unfortunately the fixed by elevating the scope at function level. new CI: https://ci.nodejs.org/job/node-test-pull-request/21287/ |
Member
Author
|
Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/21289/ (:heavy_check_mark:) |
`node::Start` creates a number of artifacts in its scope which are cleaned up in the exit path, but there is at least one path where the cleanups are bypassed. Force all paths follow the exit sequence. Refs: nodejs#21283 PR-URL: nodejs#26471 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
gireeshpunathil
force-pushed
the
runcleanup
branch
from
77db9c4 to
e029bc9
Compare
gireeshpunathil
removed
the
author ready
Member
Author
|
landed as e029bc9 |
4 tasks
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
Mar 12, 2019
`node::Start` creates a number of artifacts in its scope which are cleaned up in the exit path, but there is at least one path where the cleanups are bypassed. Force all paths follow the exit sequence. Refs: nodejs#21283 PR-URL: nodejs#26471 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
BridgeAR
pushed a commit
that referenced
this pull request
Mar 14, 2019
`node::Start` creates a number of artifacts in its scope which are cleaned up in the exit path, but there is at least one path where the cleanups are bypassed. Force all paths follow the exit sequence. Refs: #21283 PR-URL: #26471 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
node::Startcreates a number of artifacts in its scope which arecleaned up in the exit path, but there is at least one path where the
cleanups are bypassed. Force all paths follow the exit sequence.
Refs: #21283
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes