process: move more dependency of environment variables to pre-execution by joyeecheung · Pull Request #26466 · nodejs/node

joyeecheung · 2019-03-06T11:14:01Z

process: call `prepareMainThreadExecution` in `node inspect`

Since we should treat the node-inspect as third-party
user code.

process: set up process warning handler in pre-execution

Since it depends on environment variables.

process: handle process.env.NODE_V8_COVERAGE in pre-execution

Since this depends on environment variable, and the worker threads
do not need to persist the variable value because they cannot
switch cwd.

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
commit message follows commit guidelines

Since we should treat the node-inspect as third-party user code.

Since it depends on environment variables.

Since this depends on environment variable, and the worker threads do not need to persist the variable value because they cannot switch cwd.

nodejs-github-bot · 2019-03-06T11:14:04Z

@joyeecheung build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2779/pipeline

joyeecheung · 2019-03-06T11:14:40Z

CI: https://ci.nodejs.org/job/node-test-pull-request/21257/

joyeecheung · 2019-03-08T12:54:30Z

Landed in e029bc9...f617a73

Since we should treat the node-inspect as third-party user code. PR-URL: #26466 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

Since it depends on environment variables. PR-URL: #26466 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

Since this depends on environment variable, and the worker threads do not need to persist the variable value because they cannot switch cwd. PR-URL: #26466 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

BridgeAR · 2019-03-13T12:37:56Z

This breaks on v11. @joyeecheung I guess we should try to backport this to reduce other conflicts. Would you be so kind and have a look?

BridgeAR · 2019-03-13T12:39:18Z

The first commit and third commit seem fine but the warning handler breaks. The third relies on the second one though.

joyeecheung · 2019-03-13T16:51:20Z

I think this should land cleanly after #25685 is backported?

joyeecheung · 2019-03-13T16:54:31Z

Oh wait, this needs a non-semver-major form of #25828 as well

Since we should treat the node-inspect as third-party user code. PR-URL: nodejs#26466 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

Since it depends on environment variables. PR-URL: nodejs#26466 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

Since this depends on environment variable, and the worker threads do not need to persist the variable value because they cannot switch cwd. PR-URL: nodejs#26466 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

ZYSzys · 2019-03-14T13:09:51Z

This can be backported without conflicts now (after #26659) , do we still need to backport this manually(open a backport PR) ?

EDIT: there was an error if landed directly since #25828 was semver-major.

BridgeAR · 2019-03-14T13:53:44Z

@ZYSzys do you know if the tests pass as well? If so, I'll remove the label. In that case it will be pulled in the next release.

ZYSzys · 2019-03-14T14:00:27Z

@BridgeAR Sadly tests weren't passed.

This PR dependent on #25828(that was semver-major) as @joyeecheung said.

BridgeAR · 2019-03-14T14:48:04Z

@ZYSzys thanks for checking again!

refack · 2019-03-14T15:07:34Z

PR to backport #26662

Since we should treat the node-inspect as third-party user code. PR-URL: nodejs#26466 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

Since it depends on environment variables. PR-URL: nodejs#26466 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

Since this depends on environment variable, and the worker threads do not need to persist the variable value because they cannot switch cwd. PR-URL: nodejs#26466 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

Since we should treat the node-inspect as third-party user code. PR-URL: nodejs#26466 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

Since it depends on environment variables. PR-URL: nodejs#26466 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

Since this depends on environment variable, and the worker threads do not need to persist the variable value because they cannot switch cwd. PR-URL: nodejs#26466 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

Since we should treat the node-inspect as third-party user code. Backport-PR-URL: nodejs#26662 PR-URL: nodejs#26466 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

Since it depends on environment variables. Backport-PR-URL: nodejs#26662 PR-URL: nodejs#26466 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

Since this depends on environment variable, and the worker threads do not need to persist the variable value because they cannot switch cwd. Backport-PR-URL: nodejs#26662 PR-URL: nodejs#26466 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

joyeecheung added 3 commits March 6, 2019 12:02

process: call prepareMainThreadExecution in node inspect

bdbcd0f

Since we should treat the node-inspect as third-party user code.

process: set up process warning handler in pre-execution

0e97fa3

Since it depends on environment variables.

process: handle process.env.NODE_V8_COVERAGE in pre-execution

410c588

Since this depends on environment variable, and the worker threads do not need to persist the variable value because they cannot switch cwd.

joyeecheung changed the title ~~process: move more dependency of environment variabels to pre-execution~~ process: move more dependency of environment variables to pre-execution Mar 6, 2019

addaleax approved these changes Mar 6, 2019

View reviewed changes

BridgeAR approved these changes Mar 6, 2019

View reviewed changes

BridgeAR added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. process Issues and PRs related to the process subsystem. labels Mar 6, 2019

joyeecheung closed this Mar 8, 2019

BridgeAR added the backport-requested-v11.x label Mar 13, 2019

BridgeAR mentioned this pull request Mar 13, 2019

lib: explicitly initialize debuglog during bootstrap #26468

Closed

2 tasks

refack mentioned this pull request Mar 14, 2019

[v11.x backport] process: move more dependency of environment variables to pre-execution #26662

Closed

2 tasks

refack self-assigned this Mar 14, 2019

joyeecheung mentioned this pull request Mar 14, 2019

[v11.x] backport warning handler refactoring #26670

Closed

4 tasks

targos added backported-to-v11.x and removed backport-requested-v11.x labels Mar 27, 2019

targos mentioned this pull request Mar 27, 2019

v11.13.0 release proposal #26949

Merged

refack removed their assignment Apr 15, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

process: move more dependency of environment variables to pre-execution#26466

process: move more dependency of environment variables to pre-execution#26466
joyeecheung wants to merge 3 commits intonodejs:masterfrom
joyeecheung:move-env

joyeecheung commented Mar 6, 2019

Uh oh!

nodejs-github-bot commented Mar 6, 2019

Uh oh!

joyeecheung commented Mar 6, 2019

Uh oh!

joyeecheung commented Mar 8, 2019

Uh oh!

BridgeAR commented Mar 13, 2019

Uh oh!

BridgeAR commented Mar 13, 2019 •

edited

Loading

Uh oh!

joyeecheung commented Mar 13, 2019

Uh oh!

joyeecheung commented Mar 13, 2019

Uh oh!

ZYSzys commented Mar 14, 2019 •

edited

Loading

Uh oh!

BridgeAR commented Mar 14, 2019

Uh oh!

ZYSzys commented Mar 14, 2019

Uh oh!

BridgeAR commented Mar 14, 2019

Uh oh!

refack commented Mar 14, 2019 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Uh oh!

Conversation

joyeecheung commented Mar 6, 2019

process: call prepareMainThreadExecution in node inspect

process: set up process warning handler in pre-execution

process: handle process.env.NODE_V8_COVERAGE in pre-execution

Checklist

Uh oh!

nodejs-github-bot commented Mar 6, 2019

Uh oh!

joyeecheung commented Mar 6, 2019

Uh oh!

joyeecheung commented Mar 8, 2019

Uh oh!

BridgeAR commented Mar 13, 2019

Uh oh!

BridgeAR commented Mar 13, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

joyeecheung commented Mar 13, 2019

Uh oh!

joyeecheung commented Mar 13, 2019

Uh oh!

ZYSzys commented Mar 14, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

BridgeAR commented Mar 14, 2019

Uh oh!

ZYSzys commented Mar 14, 2019

Uh oh!

BridgeAR commented Mar 14, 2019

Uh oh!

refack commented Mar 14, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

process: call `prepareMainThreadExecution` in `node inspect`

BridgeAR commented Mar 13, 2019 •

edited

Loading

ZYSzys commented Mar 14, 2019 •

edited

Loading

refack commented Mar 14, 2019 •

edited

Loading