Closed
Conversation
nodejs-github-bot
added
test
richardlau
approved these changes
Mar 5, 2019
mihalskiy
approved these changes
Mar 5, 2019
timofeichaplinskiy
approved these changes
Mar 5, 2019
refack
approved these changes
Mar 5, 2019
refack
added
the
python
Member
BridgeAR
added
the
author ready
This fixes the necessary plumbing to make the --shell argument have its intended effect.
Member
Author
|
Started a new CI after fixing the nit: https://ci.nodejs.org/job/node-test-pull-request/21249/ |
danbev
pushed a commit
to danbev/node
that referenced
this pull request
Mar 8, 2019
This fixes the necessary plumbing to make the --shell argument have its intended effect. PR-URL: nodejs#26449 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
Contributor
|
Landed in ede1a7c. |
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
Mar 12, 2019
This fixes the necessary plumbing to make the --shell argument have its intended effect. PR-URL: nodejs#26449 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
BridgeAR
pushed a commit
that referenced
this pull request
Mar 14, 2019
This fixes the necessary plumbing to make the --shell argument have its intended effect. PR-URL: #26449 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
BethGriggs
pushed a commit
that referenced
this pull request
Apr 16, 2019
This fixes the necessary plumbing to make the --shell argument have its intended effect. PR-URL: #26449 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
Merged
This was referenced May 29, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the necessary plumbing to make the --shell argument
have its intended effect.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes