tools: roll inspector_protocol to f67ec5 by pavelfeldman · Pull Request #26303 · nodejs/node

pavelfeldman · 2019-02-25T20:48:24Z

addaleax · 2019-02-25T20:51:31Z

src/inspector/node_string.cc

This should probably be

Suggested change

ProtocolMessage binaryToMessage(std::vector<uint8_t> message) {

ProtocolMessage binaryToMessage(const std::vector<uint8_t>& message) {

?

Not really, we are std::move-ing binary messages around. It is likely that we switch to using std::unique_ptr<std::vector> for clarity at some point.

addaleax · 2019-02-25T20:52:20Z

src/inspector/node_string.h

Does it make sense to UNREACHABLE();? You can drop the return statements in that case.

Ah, perfect, that's what it is in v8/chromium, I was not sure if node prefers that as well.

Correction, it was UNIMPLEMENTED in v8/chromium. Anyhow, using UNREACHABLE now

targos · 2019-02-25T22:01:20Z

Is there a guide/documentation on how to update this dependency? This PR removes more lines than it adds while my try here adds 7k.

pavelfeldman · 2019-02-25T22:15:34Z

Is there a guide/documentation on how to update this dependency?

we have scripts doing that in the v8 / chromium lands, let us add another one for Node.

refack

RSLGTM

refack · 2019-02-26T00:13:23Z

@pavelfeldman, thank you for the bump.
Could you have forgotten to add renamed files?

From Travis:

make[1]: *** No rule to make target `../tools/inspector_protocol/code_generator.py', needed by `26acdf201a53d5709754b88c308e871df22184f9.intermediate'.  Stop.

pavelfeldman · 2019-02-26T00:53:14Z

Turns out I lost all the added third party files while shuffling them between the repos :/ ...

addaleax · 2019-03-02T13:14:54Z

@pavelfeldman What’s the status of this PR?

targos · 2019-03-04T14:56:51Z

I think it's ready? I confirm this PR fixes the canary builds.

refack · 2019-03-04T15:34:27Z

CI: https://ci.nodejs.org/job/node-test-pull-request/21189/

Fixes: nodejs#25808 PR-URL: nodejs#26303 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>

Fixes: #25808 PR-URL: #26303 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. labels Feb 25, 2019

pavelfeldman mentioned this pull request Feb 25, 2019

tools: update inspector_protocol #26154

Closed

addaleax approved these changes Feb 25, 2019

View reviewed changes

pavelfeldman force-pushed the inspector_protocol branch from b180034 to 73d1e25 Compare February 25, 2019 22:12

pavelfeldman force-pushed the inspector_protocol branch from 73d1e25 to 9964706 Compare February 25, 2019 23:13

pavelfeldman changed the title ~~Roll tools/inspector_protocol to f67ec5180f476830e839226b5ca948e43070…~~ tools: roll inspector_protocol to f67ec5180f476830e839226b5ca948e43070… Feb 25, 2019

pavelfeldman changed the title ~~tools: roll inspector_protocol to f67ec5180f476830e839226b5ca948e43070…~~ tools: roll inspector_protocol to f67ec5 Feb 25, 2019

pavelfeldman force-pushed the inspector_protocol branch from 9964706 to f041207 Compare February 25, 2019 23:56

refack approved these changes Feb 26, 2019

View reviewed changes

pavelfeldman force-pushed the inspector_protocol branch from f041207 to c5a8f91 Compare February 26, 2019 00:52

refack self-assigned this Mar 4, 2019

cclauss mentioned this pull request Mar 4, 2019

build: ongoing list of actions for Python 3 compatibility #25789

Closed

63 tasks

tools: roll inspector_protocol to f67ec5

d775d74

Fixes: nodejs#25808 PR-URL: nodejs#26303 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>

refack force-pushed the inspector_protocol branch from c5a8f91 to d775d74 Compare March 4, 2019 16:48

refack merged commit d775d74 into nodejs:master Mar 4, 2019

refack removed their assignment Mar 11, 2019

BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Mar 12, 2019

tools: roll inspector_protocol to f67ec5

d841a89

Fixes: nodejs#25808 PR-URL: nodejs#26303 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>

BridgeAR mentioned this pull request Mar 13, 2019

2019-03-14, Version 11.12.0 (Current) #26644

Merged

BethGriggs pushed a commit that referenced this pull request Apr 16, 2019

tools: roll inspector_protocol to f67ec5

4819296

Fixes: #25808 PR-URL: #26303 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>

BethGriggs mentioned this pull request May 1, 2019

v10.16.0 proposal #27514

Merged

This was referenced May 29, 2019

2019-05-28 Version 10.16.0 'Dubnium' (LTS) @BethGriggs beevelop/docker-android-nodejs#315

Closed

2019-05-28 Version 10.16.0 'Dubnium' (LTS) @BethGriggs beevelop/docker-android-nodejs#316

Closed

	ProtocolMessage binaryToMessage(std::vector<uint8_t> message) {
	ProtocolMessage binaryToMessage(const std::vector<uint8_t>& message) {

Uh oh!

Conversation

pavelfeldman commented Feb 25, 2019

Uh oh!

addaleax Feb 25, 2019

Choose a reason for hiding this comment

Uh oh!

pavelfeldman Feb 25, 2019

Choose a reason for hiding this comment

Uh oh!

addaleax Feb 25, 2019

Choose a reason for hiding this comment

Uh oh!

pavelfeldman Feb 25, 2019

Choose a reason for hiding this comment

Uh oh!

pavelfeldman Feb 25, 2019

Choose a reason for hiding this comment

Uh oh!

targos commented Feb 25, 2019

Uh oh!

pavelfeldman commented Feb 25, 2019

Uh oh!

refack left a comment

Choose a reason for hiding this comment

Uh oh!

refack commented Feb 26, 2019

Uh oh!

pavelfeldman commented Feb 26, 2019

Uh oh!

addaleax commented Mar 2, 2019

Uh oh!

targos commented Mar 4, 2019

Uh oh!

refack commented Mar 4, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants