test: improve test coverage in perf_hooks#26290
Closed
juanarbol wants to merge 1 commit intonodejs:masterfrom
Closed
test: improve test coverage in perf_hooks#26290juanarbol wants to merge 1 commit intonodejs:masterfrom
juanarbol wants to merge 1 commit intonodejs:masterfrom
Conversation
addaleax
approved these changes
Feb 24, 2019
targos
approved these changes
Feb 24, 2019
lpinca
approved these changes
Feb 24, 2019
jasnell
approved these changes
Feb 25, 2019
antsmartian
approved these changes
Feb 25, 2019
Member
addaleax
added
the
author ready
Contributor
BridgeAR
approved these changes
Mar 4, 2019
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
Mar 4, 2019
PR-URL: nodejs#26290 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Member
|
Landed in 3826d69 🎉 I fixed the linter issue while landing (the linter complained due to a recent change about the comment). |
Member
Author
|
@BridgeAR Thank you!!! 🎉 |
BridgeAR
pushed a commit
that referenced
this pull request
Mar 4, 2019
PR-URL: #26290 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Merged
BridgeAR
pushed a commit
that referenced
this pull request
Mar 5, 2019
PR-URL: #26290 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
BethGriggs
pushed a commit
that referenced
this pull request
Apr 16, 2019
PR-URL: #26290 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Merged
This was referenced May 29, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes