src: remove unused macro in node_http2.h#26204
Closed
gengjiawen wants to merge 1 commit intonodejs:masterfrom
Closed
src: remove unused macro in node_http2.h#26204gengjiawen wants to merge 1 commit intonodejs:masterfrom
gengjiawen wants to merge 1 commit intonodejs:masterfrom
Conversation
nodejs-github-bot
added
c++
addaleax
approved these changes
Feb 19, 2019
cjihrig
approved these changes
Feb 20, 2019
BridgeAR
approved these changes
Feb 20, 2019
Member
BridgeAR
added
the
author ready
jasnell
approved these changes
Feb 21, 2019
Member
Author
|
@BridgeAR Can you re-run the failing build ? Thanks. |
Member
Author
Member
Member
|
Windows rebuild: https://ci.nodejs.org/job/node-test-commit-windows-fanned/25066/ |
Member
|
Landed in 453ed05 |
addaleax
pushed a commit
that referenced
this pull request
Mar 1, 2019
PR-URL: #26204 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax
pushed a commit
that referenced
this pull request
Mar 2, 2019
PR-URL: #26204 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes