src: extract common sockaddr creation code#26070
Closed
danbev wants to merge 4 commits intonodejs:masterfrom
Closed
src: extract common sockaddr creation code#26070danbev wants to merge 4 commits intonodejs:masterfrom
danbev wants to merge 4 commits intonodejs:masterfrom
Conversation
This commit extracts code to create sockaddr which is shared by both UDPWrap::DoBind and UDPWrap::DoSend.
nodejs-github-bot
added
c++
Contributor
Author
addaleax
reviewed
Feb 13, 2019
Contributor
Author
addaleax
approved these changes
Feb 13, 2019
jasnell
approved these changes
Feb 14, 2019
richardlau
reviewed
Feb 14, 2019
richardlau
approved these changes
Feb 15, 2019
Member
addaleax
added
the
author ready
Contributor
Member
|
Landed in 05292cb |
addaleax
pushed a commit
that referenced
this pull request
Feb 17, 2019
This commit extracts code to create sockaddr which is shared by both UDPWrap::DoBind and UDPWrap::DoSend. PR-URL: #26070 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Richard Lau <[email protected]>
addaleax
pushed a commit
that referenced
this pull request
Feb 17, 2019
This commit extracts code to create sockaddr which is shared by both UDPWrap::DoBind and UDPWrap::DoSend. PR-URL: #26070 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Richard Lau <[email protected]>
Merged
rvagg
pushed a commit
that referenced
this pull request
Feb 28, 2019
This commit extracts code to create sockaddr which is shared by both UDPWrap::DoBind and UDPWrap::DoSend. PR-URL: #26070 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Richard Lau <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
May 16, 2019
This commit extracts code to create sockaddr which is shared by both UDPWrap::DoBind and UDPWrap::DoSend. PR-URL: #26070 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Richard Lau <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
May 16, 2019
This commit extracts code to create sockaddr which is shared by both UDPWrap::DoBind and UDPWrap::DoSend. PR-URL: #26070 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Richard Lau <[email protected]>
Merged
This was referenced May 29, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit extracts code to create sockaddr which is shared by both
UDPWrap::DoBindandUDPWrap::DoSend.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes