stream: make sure 'readable' is emitted before ending the stream by mcollina · Pull Request #26059 · nodejs/node

mcollina · 2019-02-12T21:54:41Z

This change is born out of #25810, as I explored how to fix that difference.

This change could be considered semver-major or a bug fix. We need also to check some of the benchmarks if they are impacted before landing.

Fixes #25810

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
documentation is changed or added
commit message follows commit guidelines

nodejs-github-bot · 2019-02-12T21:54:43Z

@mcollina build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2580/pipeline

lib/_stream_readable.js

test/parallel/test-stream-readable-emit-readable-short-stream.js

lpinca · 2019-02-14T20:37:53Z

test/parallel/test-stream-readable-emit-readable-short-stream.js

Nit that can be ignored, can we remove the return statement?

mcollina · 2019-03-02T19:38:46Z

CI: https://ci.nodejs.org/job/node-test-pull-request/21144/

@lpinca @jasnell PTAL

jasnell · 2019-03-02T23:21:51Z

Still LGTM

test/parallel/test-stream-readable-emittedReadable.js

Fixes: nodejs#25810

mcollina · 2019-03-04T15:31:37Z

CI: https://ci.nodejs.org/job/node-test-pull-request/21188/

test/parallel/test-stream-readable-emittedReadable.js

lpinca

This is what I mean, it saves a common.mustNotCall() call :)

test/parallel/test-stream-readable-emittedReadable.js

Co-Authored-By: mcollina <matteo.collina@gmail.com>

mcollina · 2019-03-05T16:58:31Z

I understand what you mean now!

CI: https://ci.nodejs.org/job/node-test-pull-request/21219/

mcollina · 2019-03-06T08:40:19Z

Landed in e95e7f9

Fixes: #25810 PR-URL: #26059 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

Fixes: nodejs#25810 PR-URL: nodejs#26059 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

In nodejs#26059, we introduced a bug that caused 'readable' to be nextTicked on EOF of a ReadableStream. This breaks the dicer module on CITGM. That change was partially reverted to still fix the bug in nodejs#25810 and not break dicer. See: nodejs#26059 Fixes: nodejs#25810

BridgeAR · 2019-03-14T09:59:39Z

I marked this as do not land on all release lines and I'll back this out again from the release proposal for v11.12.0.

mcollina · 2019-03-16T10:59:37Z

@BridgeAR this must land with 269103a.

In #26059, we introduced a bug that caused 'readable' to be nextTicked on EOF of a ReadableStream. This breaks the dicer module on CITGM. That change was partially reverted to still fix the bug in #25810 and not break dicer. See: #26059 Fixes: #25810 PR-URL: #26643 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

Fixes: nodejs#25810 PR-URL: nodejs#26059 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

In nodejs#26059, we introduced a bug that caused 'readable' to be nextTicked on EOF of a ReadableStream. This breaks the dicer module on CITGM. That change was partially reverted to still fix the bug in nodejs#25810 and not break dicer. See: nodejs#26059 Fixes: nodejs#25810 PR-URL: nodejs#26643 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

Fixes: #25810 PR-URL: #26059 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

In #26059, we introduced a bug that caused 'readable' to be nextTicked on EOF of a ReadableStream. This breaks the dicer module on CITGM. That change was partially reverted to still fix the bug in #25810 and not break dicer. See: #26059 Fixes: #25810 PR-URL: #26643 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

mcollina requested review from addaleax, jasnell, lpinca and mafintosh February 12, 2019 21:54

nodejs-github-bot added the stream Issues and PRs related to the stream subsystem. label Feb 12, 2019

lpinca reviewed Feb 13, 2019

View reviewed changes

lib/_stream_readable.js Outdated Show resolved Hide resolved

lpinca reviewed Feb 13, 2019

View reviewed changes

test/parallel/test-stream-readable-emit-readable-short-stream.js Outdated Show resolved Hide resolved

mcollina mentioned this pull request Feb 14, 2019

Transform stream misses final readable event for small inputs #25810

Closed

lpinca reviewed Feb 14, 2019

View reviewed changes

test/parallel/test-stream-readable-emit-readable-short-stream.js Outdated

Copy link

Member

lpinca Feb 14, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit that can be ignored, can we remove the return statement?

jasnell approved these changes Feb 15, 2019

View reviewed changes

mcollina added dont-land-on-v6.x labels Feb 15, 2019

mcollina force-pushed the readable-next-tick branch from dec410a to 833cb28 Compare March 2, 2019 19:36

lpinca reviewed Mar 3, 2019

View reviewed changes

test/parallel/test-stream-readable-emittedReadable.js Outdated Show resolved Hide resolved

stream: make sure 'readable' is emitted before ending the stream

c393c44

Fixes: nodejs#25810

mcollina force-pushed the readable-next-tick branch from 833cb28 to c393c44 Compare March 4, 2019 15:29

lpinca reviewed Mar 4, 2019

View reviewed changes

test/parallel/test-stream-readable-emittedReadable.js Outdated Show resolved Hide resolved

lpinca approved these changes Mar 4, 2019

View reviewed changes

lpinca reviewed Mar 4, 2019

View reviewed changes

test/parallel/test-stream-readable-emittedReadable.js Outdated Show resolved Hide resolved

test/parallel/test-stream-readable-emittedReadable.js Outdated Show resolved Hide resolved

lpinca and others added 2 commits March 5, 2019 16:57

Update test/parallel/test-stream-readable-emittedReadable.js

a90eb4f

Co-Authored-By: mcollina <matteo.collina@gmail.com>

Update test/parallel/test-stream-readable-emittedReadable.js

8c973a7

Co-Authored-By: mcollina <matteo.collina@gmail.com>

mcollina added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 5, 2019

mcollina closed this Mar 6, 2019

mcollina deleted the readable-next-tick branch March 6, 2019 08:40

mcollina added a commit that referenced this pull request Mar 6, 2019

stream: make sure 'readable' is emitted before ending the stream

e95e7f9

Fixes: #25810 PR-URL: #26059 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

mcollina mentioned this pull request Mar 13, 2019

streams: fix regression introduced in #26059 #26643

Closed

3 tasks

BridgeAR mentioned this pull request Mar 13, 2019

2019-03-14, Version 11.12.0 (Current) #26644

Merged

BridgeAR added dont-land-on-v10.x labels Mar 14, 2019

targos removed the dont-land-on-v11.x label Mar 27, 2019

targos pushed a commit to targos/node that referenced this pull request Mar 27, 2019

stream: make sure 'readable' is emitted before ending the stream

6dbce34

Fixes: nodejs#25810 PR-URL: nodejs#26059 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

targos pushed a commit that referenced this pull request Mar 27, 2019

stream: make sure 'readable' is emitted before ending the stream

0b2f900

Fixes: #25810 PR-URL: #26059 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

targos mentioned this pull request Mar 27, 2019

v11.13.0 release proposal #26949

Merged

BethGriggs removed the lts-watch-v10.x label Jul 9, 2019

Uh oh!

Conversation

mcollina commented Feb 12, 2019

Checklist

Uh oh!

nodejs-github-bot commented Feb 12, 2019

Uh oh!

Uh oh!

Uh oh!

lpinca Feb 14, 2019

Choose a reason for hiding this comment

Uh oh!

mcollina commented Mar 2, 2019

Uh oh!

jasnell commented Mar 2, 2019

Uh oh!

Uh oh!

mcollina commented Mar 4, 2019

Uh oh!

Uh oh!

lpinca left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

mcollina commented Mar 5, 2019

Uh oh!

mcollina commented Mar 6, 2019

Uh oh!

BridgeAR commented Mar 14, 2019

Uh oh!

mcollina commented Mar 16, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

lpinca left a comment •

edited

Loading