Closed
Conversation
lpinca
approved these changes
Feb 10, 2019
Member
|
It might be better to use two different commits as the typo has nothing to do with the other change. |
Fix a typo error ('the' before 'any').
ghost
changed the title
Author
|
@lpinca: OK, I thought it was nits and now I've forcely pushed one file :) |
Member
|
@Maledong I was suggesting to use 2 different commits, one for the I can only see the typo fix now. |
Author
richardlau
approved these changes
Feb 10, 2019
thefourtheye
approved these changes
Feb 11, 2019
BethGriggs
approved these changes
Feb 11, 2019
lance
approved these changes
Feb 11, 2019
antsmartian
approved these changes
Feb 12, 2019
jasnell
approved these changes
Feb 12, 2019
Contributor
|
Landed in 048b977. |
danbev
pushed a commit
that referenced
this pull request
Feb 13, 2019
Fix a typo error ('the' before 'any').
PR-URL: #26032
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Lance Ball <lball@redhat.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax
pushed a commit
that referenced
this pull request
Feb 13, 2019
Fix a typo error ('the' before 'any').
PR-URL: #26032
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Lance Ball <lball@redhat.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
ghost
deleted the
Author
|
Thanks all! |
Merged
This was referenced Feb 15, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For
recoverable.js: fix a typo error ('the' before 'any').make -j4 test(UNIX), orvcbuild test(Windows) passes