test: replaced anonymous fn with arrow syntax#26029
Closed
pushkalb123 wants to merge 1 commit intonodejs:masterfrom
pushkalb123:JSARROW
Closed
test: replaced anonymous fn with arrow syntax#26029pushkalb123 wants to merge 1 commit intonodejs:masterfrom pushkalb123:JSARROW
pushkalb123 wants to merge 1 commit intonodejs:masterfrom
pushkalb123:JSARROW
Conversation
nodejs-github-bot
added
addons
cjihrig
approved these changes
Feb 10, 2019
Member
gireeshpunathil
approved these changes
Feb 10, 2019
jasnell
approved these changes
Feb 11, 2019
Contributor
|
Re-run of failing node-test-commit-arm-fanned |
Member
|
Landed in 1833782 🎉 |
addaleax
pushed a commit
that referenced
this pull request
Feb 13, 2019
PR-URL: #26029 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
Feb 14, 2019
PR-URL: #26029 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
This was referenced Feb 15, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes