Skip to content

[backport 11.x] process: move setup of process warnings into node.js#26025

Closed
antsmartian wants to merge 1 commit intonodejs:v11.x-stagingfrom
antsmartian:backport-25263-11x
Closed

[backport 11.x] process: move setup of process warnings into node.js#26025
antsmartian wants to merge 1 commit intonodejs:v11.x-stagingfrom
antsmartian:backport-25263-11x

Conversation

@antsmartian
Copy link
Contributor

@antsmartian antsmartian commented Feb 10, 2019 •
edited
Loading

Backport of #25263

@antsmartian
process: move setup of process warnings into node.js
04a2393 
 To clarify the side effects and conditions of the warning setup
 during bootstrap.

 PR-URL: nodejs#25263
 Reviewed-By: Gus Caplan <me@gus.host>
 Reviewed-By: Anna Henningsen <anna@addaleax.net>
 Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Feb 10, 2019

@antsmartian build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2559/pipeline

@nodejs-github-bot nodejs-github-bot added process Issues and PRs related to the process subsystem. v11.x labels Feb 10, 2019
@antsmartian antsmartian changed the title process: move setup of process warnings into node.js [backport 11.x] process: move setup of process warnings into node.js Feb 10, 2019
@antsmartian
Copy link
Contributor Author

antsmartian commented Feb 10, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/20704/

@targos
Copy link
Member

targos commented Feb 10, 2019

Thanks @antsmartian !

targos pushed a commit that referenced this pull request Feb 10, 2019
@antsmartian @targos
process: move setup of process warnings into node.js
f4cfbf4 
To clarify the side effects and conditions of the warning setup
during bootstrap.

PR-URL: #25263
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Backport-PR-URL: #26025
@targos
Copy link
Member

targos commented Feb 10, 2019

Landed in f4cfbf4

@targos targos closed this Feb 10, 2019
@antsmartian antsmartian deleted the backport-25263-11x branch February 10, 2019 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@targos targos targos approved these changes

Assignees

No one assigned

Labels

process Issues and PRs related to the process subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@antsmartian @nodejs-github-bot @targos