process: normalize process.execPath in CreateProcessObject()#26002
process: normalize process.execPath in CreateProcessObject()#26002joyeecheung wants to merge 1 commit intonodejs:masterfrom
Conversation
Directly normalize `process.execPath` using `uv_fs_realpath`
on OpenBSD before serializing it into the process object,
instead of using `require('fs')` to normalize and override
the path in `bootstrap/node.js`.
nodejs-github-bot
added
the
c++
richardlau
left a comment
richardlau
left a comment
There was a problem hiding this comment.
Changes LGTM but I wonder whether the original change for OpenBSD should have been pushed up to libuv.
|
I second what Richard says. If |
I agree with that too. The only issue is that we don't test OpenBSD in the CI (AFAIK), so someone would have to set that up first to fix it with any confidence. |
|
I agree this can be done in libuv instead, though this just moves what we already do to the C++. We can come back removing the special case code when this gets done in the upstream. |
|
Landed in af83f6a |
Directly normalize `process.execPath` using `uv_fs_realpath`
on OpenBSD before serializing it into the process object,
instead of using `require('fs')` to normalize and override
the path in `bootstrap/node.js`.
PR-URL: nodejs#26002
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Directly normalize `process.execPath` using `uv_fs_realpath`
on OpenBSD before serializing it into the process object,
instead of using `require('fs')` to normalize and override
the path in `bootstrap/node.js`.
PR-URL: #26002
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
7 participants
Directly normalize
process.execPathusinguv_fs_realpathon OpenBSD before serializing it into the process object,
instead of using
require('fs')to normalize and overridethe path in
bootstrap/node.js.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes