src: remove redundant cast in node_file.cc#25977
Closed
gengjiawen wants to merge 1 commit intonodejs:masterfrom
Closed
src: remove redundant cast in node_file.cc#25977gengjiawen wants to merge 1 commit intonodejs:masterfrom
gengjiawen wants to merge 1 commit intonodejs:masterfrom
Conversation
nodejs-github-bot
added
c++
addaleax
approved these changes
Feb 7, 2019
gengjiawen
force-pushed
the
remove_redundant_cast
branch
from
2c6ada3 to
f1bbaa9
Compare
cjihrig
approved these changes
Feb 7, 2019
Member
addaleax
added
the
author ready
Contributor
|
Landed in 851cebb. |
danbev
pushed a commit
that referenced
this pull request
Feb 11, 2019
PR-URL: #25977 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
targos
pushed a commit
that referenced
this pull request
Feb 11, 2019
PR-URL: #25977 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
This was referenced Feb 15, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes