Skip to content

src: fix return type in Hash#25936

Closed
gengjiawen wants to merge 1 commit intonodejs:masterfrom
gengjiawen:fix_type_in_Hash
Closed

src: fix return type in Hash#25936
gengjiawen wants to merge 1 commit intonodejs:masterfrom
gengjiawen:fix_type_in_Hash

Conversation

@gengjiawen
Copy link
Member

@gengjiawen gengjiawen commented Feb 5, 2019

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Feb 5, 2019
addaleax
addaleax reviewed Feb 5, 2019
View reviewed changes
@gengjiawen gengjiawen force-pushed the fix_type_in_Hash branch 2 times, most recently from 00f859a to f37d729 Compare February 5, 2019 02:42
@danbev
Copy link
Contributor

danbev commented Feb 8, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/20658/

@addaleax
Copy link
Member

addaleax commented Feb 9, 2019

Landed in ea2350b

@addaleax addaleax closed this Feb 9, 2019
addaleax pushed a commit that referenced this pull request Feb 9, 2019
@gengjiawen @addaleax
src: fix return type in Hash
ea2350b 
PR-URL: #25936
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Feb 10, 2019
@gengjiawen @targos
src: fix return type in Hash
85d5f67 
PR-URL: #25936
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos mentioned this pull request Feb 14, 2019
Merged
This was referenced Feb 15, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bnoordhuis bnoordhuis bnoordhuis approved these changes

@jasnell jasnell jasnell approved these changes

@addaleax addaleax addaleax approved these changes

@cjihrig cjihrig cjihrig approved these changes

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@gengjiawen @danbev @addaleax @bnoordhuis @jasnell @cjihrig @nodejs-github-bot