src: avoid name clash with upper scope in node_trace_buffer.cc#25920
Closed
gengjiawen wants to merge 1 commit intonodejs:masterfrom
Closed
src: avoid name clash with upper scope in node_trace_buffer.cc#25920gengjiawen wants to merge 1 commit intonodejs:masterfrom
gengjiawen wants to merge 1 commit intonodejs:masterfrom
Conversation
nodejs-github-bot
added
the
c++
Member
|
This conflicts with #25896. I also find it confusing: These are the same objects, so referring to them by the same name makes sense, right? |
Member
Author
|
They are in the same function, so better with different name IMHO. |
gengjiawen
force-pushed
the
feature/redability_node_trace_buffer
branch
from
aff0acc to
f25d583
Compare
gengjiawen
force-pushed
the
feature/redability_node_trace_buffer
branch
from
f25d583 to
6c18ed9
Compare
Member
Author
|
Current there is three buffer in this method, give those different name will make it more readable |
Member
Author
|
@addaleax give this another thought or leave it the old way ? |
Member
|
@gengjiawen Yeah, I’m still -1 on doing this. You can wait for others to chime in, if you want. |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make -j4 test(UNIX), orvcbuild test(Windows) passes