src: refactor macro to std::min in node_buffer.cc

[gengjiawen]

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• commit message follows commit guidelines

[addaleax]

We use std::min elsewhere in our code, maybe it’s best to just replace the macro usage with that?

[gengjiawen]

@addaleax I will give it a try.

[refack]

CI: https://ci.nodejs.org/job/node-test-pull-request/20573/

[gengjiawen]

Since we can't now format the whole file, I run into some issue on windows wsl:

Formatting C++ diff from HEAD..
  File "tools/clang-format/node_modules/.bin/git-clang-format", line 2
    basedir=$(dirname "$(echo "$0" | sed -e 's,\\,/,g')")
            ^
SyntaxError: invalid syntax
Makefile:1254: recipe for target 'format-cpp' failed
make: *** [format-cpp] Error 1

[addaleax]

@gengjiawen That is npm trying to work around the lack of symlinks on Windows…

If you look at the definition of format-cpp in the Makefile, I think you might be able to resolve this by replacing .bin/git-clang-format and .bin/clang-format with their respective targets (clang-format/bin/git-clang-format and clang-format/index.js)?

[gengjiawen]

@addaleax Thanks. I already clang-format the whole file. revert unrelated change. Easier when I get help from CLion :)

[gengjiawen]

In the long run we should will try to make it more easier as described in #25908. I will try to invest more on this recently.

[addaleax]

Landed in 2fa6376