src: make deleted function public in agent.h#25909
Closed
gengjiawen wants to merge 1 commit intonodejs:masterfrom
Closed
src: make deleted function public in agent.h#25909gengjiawen wants to merge 1 commit intonodejs:masterfrom
gengjiawen wants to merge 1 commit intonodejs:masterfrom
Conversation
Signed-off-by: gengjiawen <technicalcute@gmail.com>
nodejs-github-bot
added
the
c++
bnoordhuis
approved these changes
Feb 3, 2019
Member
bnoordhuis
left a comment
bnoordhuis
left a comment
There was a problem hiding this comment.
LGTM but can you explain why in the commit log? This is like your other PR, right?
Member
Author
|
@bnoordhuis not quite sure which part you mean.I check the commit log, looks like right to me. |
danbev
approved these changes
Feb 6, 2019
Contributor
Contributor
|
Re-run of failing node-test-commit-arm/ |
Member
Author
|
@danbev Do I need to rebase my code ? |
Contributor
I don't thinks so, I've re-run the failing build once more and it now passes: |
Contributor
|
Landed in 3a02d39. |
danbev
pushed a commit
that referenced
this pull request
Feb 8, 2019
Signed-off-by: gengjiawen <technicalcute@gmail.com> PR-URL: #25909 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
addaleax
pushed a commit
that referenced
this pull request
Feb 8, 2019
Signed-off-by: gengjiawen <technicalcute@gmail.com> PR-URL: #25909 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Merged
This was referenced Feb 15, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make -j4 test(UNIX), orvcbuild test(Windows) passes