report: include information about event loop itself#25906
Closed
addaleax wants to merge 2 commits intonodejs:masterfrom
Closed
report: include information about event loop itself#25906addaleax wants to merge 2 commits intonodejs:masterfrom
addaleax wants to merge 2 commits intonodejs:masterfrom
Conversation
nodejs-github-bot
added
the
c++
cjihrig
approved these changes
Feb 3, 2019
richardlau
approved these changes
Feb 3, 2019
Member
Author
|
(I’m marking this as |
addaleax
force-pushed
the
node-report-loop
branch
from
e84cff2 to
2b67f5b
Compare
addaleax
added
author ready
Member
Author
|
Okay, rebased this against #25910. |
Member
Author
jasnell
approved these changes
Feb 6, 2019
Member
Author
|
Landed in 91adbe1 |
addaleax
added a commit
that referenced
this pull request
Feb 6, 2019
PR-URL: #25906 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax
added a commit
that referenced
this pull request
Feb 6, 2019
PR-URL: #25906 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
This was referenced Feb 15, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes