test: refactor test-http-agent-timeout-option (again)#25886
Closed
lpinca wants to merge 1 commit intonodejs:masterfrom
Closed
test: refactor test-http-agent-timeout-option (again)#25886lpinca wants to merge 1 commit intonodejs:masterfrom
lpinca wants to merge 1 commit intonodejs:masterfrom
Conversation
There is no need to establish a TCP connection. It is sufficient to test that the listener that forwards the `'timeout'` event from the socket to the `ClientRequest` instance is added to the socket.
gireeshpunathil
approved these changes
Feb 2, 2019
addaleax
approved these changes
Feb 6, 2019
Member
addaleax
added
the
author ready
Member
Author
|
Landed in b8d9d4a. |
lpinca
added a commit
that referenced
this pull request
Feb 7, 2019
There is no need to establish a TCP connection. It is sufficient to test that the listener that forwards the `'timeout'` event from the socket to the `ClientRequest` instance is added to the socket. PR-URL: #25886 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
addaleax
pushed a commit
that referenced
this pull request
Feb 7, 2019
There is no need to establish a TCP connection. It is sufficient to test that the listener that forwards the `'timeout'` event from the socket to the `ClientRequest` instance is added to the socket. PR-URL: #25886 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Merged
This was referenced Feb 15, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is no need to establish a TCP connection. It is sufficient to
test that the listener that forwards the
'timeout'event from thesocket to the
ClientRequestinstance is added to the socket.Refs: #25854 (comment)
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes