fix a few minor issues flagged by lgtm

[rneatherway]

• Implicit string concatenation caused the inspector PRESUBMIT to
  ignore some files
• Spurious additional passed argument to afterShutdown
• Confusing (but correct) regex using A-z character range by
  accident

I'm one of the developers behind https://lgtm.com and I was browsing the nodejs code over there at https://lgtm.com/projects/g/nodejs/node. I found these fairly simple issues that I could fix, hope this is helpful.

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• commit message follows commit guidelines

[devsnek]

files in the deps folder should be modified by submitting a patch to the relevent upstream project. the other stuff looks fine.

[eugeneo]

This is V8 issue. Can you report it there?

[rneatherway]

It looks like this file was deleted upstream in October last year. I'll back this change out in any case.

[sam-github]

I haven't traced through the C++ side here, but Isuspect that in the async case, .oncomplete is called with an arg, a status. It happens that afterShutdown() doesn't use it ATM, but if it ever did, this sync call here would be wrong for not passing success/0. Maybe it would be better for afterShutdown() to add the arg, and then comment that its not used?

[addaleax]

@sam-github Your assumptions are correct 👍

[rneatherway]

Sure, I can make that change.

[sam-github]

tools/cpplint.py is also periodically merged from upstream. We have to maintain patches, so probably better to have as few as possible. It looks like the regex there is allowing chars by accident that are not syntactically possible in C++, so are caught by compiler. That should likely be upstreamed to https://github.com/cpplint/cpplint/ and we'll get it back next time we sync to upstream.

/cc @refack (last person who synced cpplint)

[richardlau]

tools/cpplint.py is also periodically merged from upstream. We have to maintain patches, so probably better to have as few as possible. It looks like the regex there is allowing chars by accident that are not syntactically possible in C++, so are caught by compiler. That should likely be upstreamed to https://github.com/cpplint/cpplint/ and we'll get it back next time we sync to upstream.

/cc @refack (last person who synced cpplint)

The lines being changed in this PR is from one of our floating patches: cbc3dd9#diff-648c2189bda313e553284785c602c91d

[rneatherway]

The lines being changed in this PR is from one of our floating patches: cbc3dd9#diff-648c2189bda313e553284785c602c91d

Shall I leave this part as is in that case?

[refack]

Shall I leave this part as is in that case?

Sure.

[refack]

CI: https://ci.nodejs.org/job/node-test-pull-request/20592/

@sam-github you copacetic with current state?

[refack]

Resume: https://ci.nodejs.org/job/node-test-commit/25639/

[rneatherway]

Great, the CI passed.

[refack]

@rneatherway thanks for the contribution!
Congratulations on getting promoted by GitHub from

to

Hope to see you contribute more in the future 🎉

[rneatherway]

Thanks for merging :-)

If you'd like to know if these kinds of issues pop up on PRs in the future you can enable our code review integration at https://lgtm.com/projects/g/nodejs/node/ci/