src: use struct as arguments to node::Assert

[addaleax]

This just makes the code a bit more obvious (subjectively).

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• commit message follows commit guidelines

[nodejs-github-bot]

@addaleax build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2482/pipeline

[refack]

If you're here, would you consider de-crufting this? i.e.:

    if (!(expr)) {                                                             \
      node::Assert({ __FILE__, __LINE__, #expr, PRETTY_FUNCTION_NAME });       \
    }                                                                          \

[addaleax]

@refack At least locally (gcc-7 on Ubuntu 18.04), that would undo the purpose of this (what the comment is referring to): It would put the object construction in-line into the code instead of ending up as a simple pointer load from the read-only data section.

[refack]

So how about:

    if (!(expr)) {                                                             \
      static constexpr args{ __FILE__, __LINE__, #expr, PRETTY_FUNCTION_NAME } \
      node::Assert(args);                                                      \
    }

[addaleax]

@refack You are talking about const → constexpr, right? That has the same result for me, and I don’t see it as being clearer about the intention here (having an explicit, hardcoded object in the read-only data section).

I’ll make the comment more explicit about what the idea here is.

[addaleax]

CI: https://ci.nodejs.org/job/node-test-pull-request/20519/

[addaleax]

CI: https://ci.nodejs.org/job/node-test-pull-request/20538/ (✔️)

[addaleax]

Landed in 30545a5