deps: update V8 to 7.3

[targos]

ETA: Mar 12th, 2019
Intented to superseed #24875.

[nodejs-github-bot]

@targos build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2468/pipeline

[targos]

CI: https://ci.nodejs.org/view/Node.js/job/node-test-pull-request/20479/

[ryzokuken]

🎉

[targos]

Just borrowed a fix that I forgot from canary (ce3f801, squashed into 7b30762)

[targos]

New CI: https://ci.nodejs.org/view/Node.js/job/node-test-pull-request/20485/
V8: https://ci.nodejs.org/job/node-test-commit-v8-linux/2062/

/cc @nodejs/v8-update

[targos]

This version adds support for async stack traces 🎉

async function a() {
  await 1;
  await b();
}

async function b() {
  await 2;
  await c();
}

async function c() {
  await 3;
  throw new Error('boom');
}

a().catch(console.error)

Node.js 11.9.0:

Error: boom
    at c (/home/mzasso/git/nodejs/v8-7.3/test.js:13:9)
    at process.runNextTicks [as _tickCallback] (internal/process/next_tick.js:47:5)
    at Function.Module.runMain (internal/modules/cjs/loader.js:800:11)
    at executeUserCode (internal/bootstrap/node.js:526:15)
    at startMainThreadExecution (internal/bootstrap/node.js:439:3)

Node.js 12.0.0-pre:

Error: boom
    at c (/home/mzasso/git/nodejs/v8-7.3/test.js:13:9)
    at process.runNextTicks [as _tickCallback] (internal/process/next_tick.js:47:5)
    at Function.Module.runMain (internal/modules/cjs/loader.js:801:11)
    at internal/main/run_main_module.js:27:11
    at async b (/home/mzasso/git/nodejs/v8-7.3/test.js:8:3)
    at async a (/home/mzasso/git/nodejs/v8-7.3/test.js:3:3)

[targos]

And we have a new Windows compile error: https://ci.nodejs.org/job/node-compile-windows/24110/label=win-vs2017/console

/cc @nodejs/platform-windows

[targos]

AIX also failed: https://ci.nodejs.org/job/node-test-commit-aix/20779/nodes=aix61-ppc64/console

/cc @nodejs/platform-aix

[mhdawson]

@john-yan just validating that this is the issue you are already aware of for AIX/7.3?

[john-yan]

@mhdawson potential fix for the AIX issue showing in the CI is on https://chromium-review.googlesource.com/c/v8/v8/+/1448711. However, there might be more test case issues after that.

[targos]

@nodejs/platform-smartos One small issue: https://ci.nodejs.org/job/node-test-commit-smartos/23478/nodes=smartos16-64/console

20:44:39 dtrace: failed to compile script src/v8ustack.d: line 378: failed to resolve V8DBG_CLASS_JSFUNCTION__SHARED__SHAREDFUNCTIONINFO: Unknown variable name

[targos]

Problem with ubuntu1604_sharedlibs_shared_x64: https://ci.nodejs.org/job/node-test-commit-linux-containered/10363/nodes=ubuntu1604_sharedlibs_shared_x64/console

19:50:13 /home/iojs/build/workspace/node-test-commit-linux-containered/out/Release/obj.target/v8_snapshot/deps/v8/src/setup-isolate-deserialize.o: In function `v8::internal::SetupIsolateDelegate::SetupBuiltins(v8::internal::Isolate*)':
19:50:13 setup-isolate-deserialize.cc:(.text._ZN2v88internal20SetupIsolateDelegate13SetupBuiltinsEPNS0_7IsolateE+0x0): multiple definition of `v8::internal::SetupIsolateDelegate::SetupBuiltins(v8::internal::Isolate*)'
19:50:13 /home/iojs/build/workspace/node-test-commit-linux-containered/out/Release/obj.target/v8_init/deps/v8/src/setup-isolate-full.o:setup-isolate-full.cc:(.text._ZN2v88internal20SetupIsolateDelegate13SetupBuiltinsEPNS0_7IsolateE+0x0): first defined here
19:50:13 /home/iojs/build/workspace/node-test-commit-linux-containered/out/Release/obj.target/v8_snapshot/deps/v8/src/setup-isolate-deserialize.o: In function `v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*)':
19:50:13 setup-isolate-deserialize.cc:(.text._ZN2v88internal20SetupIsolateDelegate9SetupHeapEPNS0_4HeapE+0x0): multiple definition of `v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*)'
19:50:13 /home/iojs/build/workspace/node-test-commit-linux-containered/out/Release/obj.target/v8_init/deps/v8/src/setup-isolate-full.o:setup-isolate-full.cc:(.text._ZN2v88internal20SetupIsolateDelegate9SetupHeapEPNS0_4HeapE+0x0): first defined here
19:50:13 collect2: error: ld returned 1 exit status
19:50:13 node_lib.target.mk:397: recipe for target '/home/iojs/build/workspace/node-test-commit-linux-containered/out/Release/obj.target/libnode.so.70' failed
19:50:13 make[2]: *** [/home/iojs/build/workspace/node-test-commit-linux-containered/out/Release/obj.target/libnode.so.70] Error 1

[refack]

Windows should build - https://ci.nodejs.org/view/Node.js/job/node-test-pull-request/20534/
https://ci.nodejs.org/job/node-test-pull-request/20536/
https://ci.nodejs.org/job/node-test-pull-request/20537/

[targos]

Thanks for the fixes @refack! I confirm it builds on my Windows machine. Are the changes in deps/v8 upstreamable?

[refack]

I confirm it builds on my Windows machine. Are the changes in deps/v8 upstreamable?

From a quick look 3cc8b41 and 3cc8b41 are obsolete (those code areas where changed in a non trivial way).
6fe3c17 might be.

The rest are gyp files changes.

CI on Windows https://ci.nodejs.org/job/node-test-commit-windows-fanned/24450/ ✔️

[cjihrig]

@nodejs/platform-smartos One small issue: https://ci.nodejs.org/job/node-test-commit-smartos/23478/nodes=smartos16-64/console

@targos the postmortem debugging metadata breakage should be fixed by https://chromium-review.googlesource.com/c/v8/v8/+/1450144

[targos]

@refack do you want to try and open a CL for 6fe3c17 ?

[targos]

I opened a merge request for the postmortem metadata fix: https://bugs.chromium.org/p/v8/issues/detail?id=8792

[refack]

do you want to try and open a CL for 6fe3c17 ?

https://chromium-review.googlesource.com/c/v8/v8/+/1456620 ¯\(ツ)/¯

[jkunkee]

Hi! I'm working on the ARM64 Windows port of Node.js, and this PR is rather critical to it. I have a v8 build config that repros the deleted function error, so if you'd like I can lift the DISALLOW_IMPLICIT_CONSTRUCTORS fixes upstream.

I'm also happy to inquire about any the v8 issues and CLs raised here.

Is there anything else I can do to help?

[refack]

Hi @jkunkee, feel free to lift my patch upstream... If there's anything I can do to help, feel free to ping me.

[jkunkee]

Happily, @refack, it looks like the DISALLOW_IMPLICIT_CONSTRUCTORS patch has already been done: v8/v8@9e060e4