Conversation
nodejs-github-bot
added
the
lib / src
Member
Author
|
/cc @nodejs/repl |
richardlau
reviewed
Jan 31, 2019
tools/license-builder.sh
Outdated
Member
There was a problem hiding this comment.
Do we need to add acorn-walk separately?
Member
Author
There was a problem hiding this comment.
I'm not sure.
acorn is a monorepo: https://github.com/acornjs/acorn
The license files are exactly the same, and I changed the license-builder to read one of them but it still says deps/acorn, which includes both packages.
Member
|
👀 Acorn bumped to 6.0.7. |
acorn and acorn-walk are now published as two different packages. Put them both in subdirectories of `deps/acorn`. Adapt the REPL's recoverable error detection to use the new API for extending acorn parsers.
Member
Author
|
Updated to 6.0.7 |
Member
Author
BridgeAR
approved these changes
Feb 6, 2019
BridgeAR
added
the
author ready
Contributor
|
Re-run of failing node-test-commit-arm |
Member
Author
|
Re-run again: https://ci.nodejs.org/job/node-test-commit-arm/22031/ |
targos
added a commit
to targos/node
that referenced
this pull request
Feb 8, 2019
acorn and acorn-walk are now published as two different packages. Put them both in subdirectories of `deps/acorn`. Adapt the REPL's recoverable error detection to use the new API for extending acorn parsers. PR-URL: nodejs#25844 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Member
Author
|
Landed in 582c122 |
addaleax
pushed a commit
that referenced
this pull request
Feb 8, 2019
acorn and acorn-walk are now published as two different packages. Put them both in subdirectories of `deps/acorn`. Adapt the REPL's recoverable error detection to use the new API for extending acorn parsers. PR-URL: #25844 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Merged
This was referenced Feb 15, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
acorn and acorn-walk are now published as two different packages. Put
them both in subdirectories of
deps/acorn.Adapt the REPL's recoverable error detection to use the new API for
extending acorn parsers.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes