inspector,vm: remove --eval wrapper#25832
Closed
addaleax wants to merge 1 commit intonodejs:masterfrom
Closed
Conversation
Report the actual source code when running with `--eval` and `--inspect-brk`, by telling the vm module to break on the first line of the script being executed rather than wrapping the source code in a function.
addaleax
added
vm
nodejs-github-bot
added
c++
eugeneo
approved these changes
Jan 30, 2019
jdalton
reviewed
Jan 30, 2019
| filename: ${JSON.stringify(name)}, | ||
| displayErrors: true, | ||
| [kVmBreakFirstLineSymbol]: ${!!breakFirstLine} | ||
| });\n`; |
Member
There was a problem hiding this comment.
@addaleax The kVmBreakFirstLineSymbol looks pretty handy. Is there a reason to keep it hidden and not exposed as a user facing option like a boolean breakFirstLineSymbol options property?
Member
Author
There was a problem hiding this comment.
@jdalton Err, it’s less work for this PR? 😄 I’m not sure, but I guess it also only works while the inspector is enabled, similar to debugger; statements?
Somebody from @nodejs/v8-inspector might know more.
joyeecheung
approved these changes
Jan 31, 2019
Member
joyeecheung
left a comment
joyeecheung
left a comment
There was a problem hiding this comment.
Supersedes #24946 (which uses debugger;), this just removes the wrapper entirely so the source panel is cleaner in the inspector UI.
Member
Author
|
@joyeecheung Sorry, I wasn’t aware of that PR – it looks like that mostly consists of test changes that we could still apply, right? |
Member
Author
addaleax
added
the
author ready
Member
Author
Member
Author
|
Landed in cca897e |
addaleax
added a commit
that referenced
this pull request
Feb 3, 2019
Report the actual source code when running with `--eval` and `--inspect-brk`, by telling the vm module to break on the first line of the script being executed rather than wrapping the source code in a function. PR-URL: #25832 Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
addaleax
added a commit
that referenced
this pull request
Feb 3, 2019
Report the actual source code when running with `--eval` and `--inspect-brk`, by telling the vm module to break on the first line of the script being executed rather than wrapping the source code in a function. PR-URL: #25832 Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Merged
This was referenced Feb 15, 2019
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Report the actual source code when running with
--evaland--inspect-brk, by telling the vm module to break on thefirst line of the script being executed rather than wrapping
the source code in a function.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes