process: expose process.features.inspector

[joyeecheung]

Instead of using process.config.variables.v8_enable_inspector
to detect whether inspector is enabled in the build.

Refs: #25343

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• commit message follows commit guidelines

[nodejs-github-bot]

@joyeecheung build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2449/pipeline

[joyeecheung]

CI: https://ci.nodejs.org/job/node-test-pull-request/20443/

[richardlau]

I'm not sure it's worth increasing the surface area of common for this as it's only used in one place?

[richardlau]

withoutintl build test failures are because hasInspector is currently only defined if NODE_HAVE_I18N_SUPPORT so process.features.inspector ends up being undefined instead of a boolean:

node/src/node_config.cc

Lines 48 to 70 in 5860614

	#ifdef NODE_HAVE_I18N_SUPPORT
	READONLY_TRUE_PROPERTY(target, "hasIntl");
	#ifdef NODE_HAVE_SMALL_ICU
	READONLY_TRUE_PROPERTY(target, "hasSmallICU");
	#endif // NODE_HAVE_SMALL_ICU
	#if NODE_USE_V8_PLATFORM
	READONLY_TRUE_PROPERTY(target, "hasTracing");
	#endif
	#if HAVE_INSPECTOR
	READONLY_TRUE_PROPERTY(target, "hasInspector");
	#else
	READONLY_FALSE_PROPERTY(target, "hasInspector");
	#endif
	#if !defined(NODE_WITHOUT_NODE_OPTIONS)
	READONLY_TRUE_PROPERTY(target, "hasNodeOptions");
	#endif
	#endif // NODE_HAVE_I18N_SUPPORT

e.g.

not ok 1449 parallel/test-process-features

11:23:42 not ok 1449 parallel/test-process-features
11:23:42   ---
11:23:42   duration_ms: 0.147
11:23:42   severity: fail
11:23:42   exitcode: 1
11:23:42   stack: |-
11:23:42     assert.js:86
11:23:42       throw new AssertionError(obj);
11:23:42       ^
11:23:42     
11:23:42     AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:
11:23:42     + actual - expected
11:23:42     
11:23:42     + 'undefined'
11:23:42     - 'boolean'
11:23:42         at Object.<anonymous> (/home/iojs/build/workspace/node-test-commit-linux-containered/test/parallel/test-process-features.js:20:10)
11:23:42         at Module._compile (internal/modules/cjs/loader.js:737:30)
11:23:42         at Object.Module._extensions..js (internal/modules/cjs/loader.js:748:10)
11:23:42         at Module.load (internal/modules/cjs/loader.js:629:32)
11:23:42         at tryModuleLoad (internal/modules/cjs/loader.js:572:12)
11:23:42         at Function.Module._load (internal/modules/cjs/loader.js:564:3)
11:23:42         at Function.Module.runMain (internal/modules/cjs/loader.js:802:12)
11:23:42         at internal/main/run_main_module.js:27:11
11:23:42   ...

[joyeecheung]

@richardlau Thanks for the analysis, I've removed skipIfInspectorEnabled from test/common/index.js and pulled the hasInspector property initialization out of the NODE_HAVE_I18N_SUPPORT branch - it should be fine to use HAVE_INSPECTOR alone for this.

[joyeecheung]

CI: https://ci.nodejs.org/job/node-test-pull-request/20453/

[joyeecheung]

Previous fixup didn't get the test.py indentation right. Fixed. CI: https://ci.nodejs.org/job/node-test-pull-request/20499/

[joyeecheung]

Landed in c2359bd

[addaleax]

@joyeecheung This also needs to be backported to v11.x manually