events: onceWrapper returns target value#25818
Closed
himself65 wants to merge 1 commit intonodejs:masterfrom
himself65:master
Closed
events: onceWrapper returns target value#25818himself65 wants to merge 1 commit intonodejs:masterfrom himself65:master
himself65 wants to merge 1 commit intonodejs:masterfrom
himself65:master
Conversation
nodejs-github-bot
added
the
events
bnoordhuis
reviewed
Feb 4, 2019
Member
bnoordhuis
left a comment
bnoordhuis
left a comment
There was a problem hiding this comment.
Can you add one or more regression tests?
Member
Author
I will try that |
Member
Author
|
@bnoordhuis added And my computer so slow, I can't do a local test 😥 |
lpinca
approved these changes
Feb 9, 2019
Member
|
@himself65 subsystem in commit message should be |
Member
himself65
changed the title
Member
|
Fixes: #25817 |
BridgeAR
approved these changes
Mar 4, 2019
BridgeAR
added
the
author ready
cjihrig
approved these changes
Mar 4, 2019
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
Mar 5, 2019
PR-URL: nodejs#25818 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Member
|
Landed in acc506c @himself65 congratulations on your first commit to Node.js! 🎉 |
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
Mar 12, 2019
PR-URL: nodejs#25818 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
BethGriggs
pushed a commit
that referenced
this pull request
Apr 16, 2019
PR-URL: #25818 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
This was referenced May 29, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes